Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go get to make install to fix a missing dependency #355

Closed
wants to merge 1 commit into from

Conversation

philipnrmn
Copy link

Without the go get ./... step, a newly configured environment does not
automatically import the ffjson and uuid libraries, causing make install to
fail due to missing dependencies.

Without the `go get ./...` step, a newly configured environment does not
automatically import the ffjson and uuid libraries, causing `make install` to
fail due to missing depencies.
@philipnrmn philipnrmn requested a review from jdef July 19, 2018 00:55
@coveralls
Copy link

coveralls commented Jul 19, 2018

Coverage Status

Coverage increased (+0.4%) to 58.367% when pulling 7a7a971 on philipnrmn/goget into 29de6ff on master.

@jdef
Copy link
Contributor

jdef commented Jul 19, 2018

Thanks for the PR! It sounds like the dependencies are out of date. make sync should get everything needed to build the project. Instead of executing go-get, I think we should fix the dependencies so that make sync works as expected.

@philipnrmn philipnrmn closed this Sep 10, 2018
@philipnrmn philipnrmn deleted the philipnrmn/goget branch September 10, 2018 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants