Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use logging with formatting when argument is passed #371

Merged
merged 1 commit into from
May 18, 2019
Merged

Use logging with formatting when argument is passed #371

merged 1 commit into from
May 18, 2019

Conversation

eclipseo
Copy link
Contributor

Signed-off-by: Robert-André Mauchin zebob.m@gmail.com

@eclipseo
Use logging with formatting when argument is passed
27ab1bc 
Signed-off-by: Robert-André Mauchin <zebob.m@gmail.com>
@eclipseo
Copy link
Contributor Author

Avoid errors like:


github.com/mesos/mesos-go/api/v0/scheduler
# github.com/mesos/mesos-go/api/v0/scheduler
./scheduler.go:763:2: Infoln call has possible formatting directive %q
FAIL	github.com/mesos/mesos-go/api/v0/scheduler [build failed]

@coveralls
Copy link

Coverage Status

Coverage remained the same at 59.176% when pulling 27ab1bc on eclipseo:fix_logging into ee67238 on mesos:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 59.176% when pulling 27ab1bc on eclipseo:fix_logging into ee67238 on mesos:master.

jdef
jdef approved these changes May 18, 2019
View reviewed changes
Copy link
Contributor

@jdef jdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@jdef jdef merged commit 2b48b4c into mesos:master May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdef jdef jdef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eclipseo @coveralls @jdef