Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade shrinkwrap #590

Merged
merged 4 commits into from
Mar 9, 2016
Merged

Upgrade shrinkwrap #590

merged 4 commits into from
Mar 9, 2016

Conversation

Poltergeist
Copy link
Contributor

This is removing the npm-shrinkwrap and using the native npm shrinkwrap

@Poltergeist
Copy link
Contributor Author

First commit Performance
image
on Travis

@Poltergeist
Copy link
Contributor Author

second commit
image

@Poltergeist
Copy link
Contributor Author

Starting point
image
taken from: https://travis-ci.org/mesosphere/marathon-ui/builds/105222976

@Poltergeist
Copy link
Contributor Author

Third commit:
image

@Poltergeist
Copy link
Contributor Author

Fourth commit
image

@Poltergeist Poltergeist mentioned this pull request Feb 5, 2016
Merged
@Poltergeist Poltergeist force-pushed the build/upgrade-shrinkwrap branch 2 times, most recently from 46ed871 to 1283833 Compare February 19, 2016 18:38
@Poltergeist
Copy link
Contributor Author

The React part has been removed.

@Poltergeist Poltergeist changed the title [Do not merge] Change npm shrinkwrap to current version Upgrade shrinkwrap & upgrade react to 0.14 Feb 19, 2016
@pierluigi
Copy link
Contributor

Related issue: mesosphere/marathon#2710

@Poltergeist Poltergeist force-pushed the build/upgrade-shrinkwrap branch 2 times, most recently from c730d6f to bcafb01 Compare February 22, 2016 15:12
@pierluigi pierluigi changed the title Upgrade shrinkwrap & upgrade react to 0.14 Upgrade shrinkwrap Mar 9, 2016
@aldipower
Copy link
Contributor

Works also on my machine! Nice thing.

pierluigi pushed a commit that referenced this pull request Mar 9, 2016
Merge pull request #590 from mesosphere/build/upgrade-shrinkwrap
7ec045b 
Upgrade shrinkwrap
@pierluigi pierluigi merged commit 7ec045b into master Mar 9, 2016
@pierluigi pierluigi deleted the build/upgrade-shrinkwrap branch March 9, 2016 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Poltergeist @pierluigi @aldipower