Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCOS-15407, DCOS-15570: Adding support for the new API #803

Merged
merged 6 commits into from
May 10, 2017

Conversation

wavesoft
Copy link
Contributor

@wavesoft wavesoft commented May 9, 2017

This PR introduces proper support for the new networking API to the marathon UI. In detail:

  • Re-mapped container.docker.portMapping to container.portMapping
  • Re-mapped container.docker.network to networks and
  • Added high-level tranformation for networks array
  • Ensuring a default network (host) always exist
  • Detecting when multiple networks are specified
  • Disabling respective UI sections when multiple networks are detected

Copy link
Contributor

@Poltergeist Poltergeist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM All changes do make sense.

@Poltergeist Poltergeist merged commit ba45653 into master May 10, 2017
@Poltergeist Poltergeist deleted the ic/fix/DCOS-15407-add-new-api-support branch May 10, 2017 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants