Read command line options from MARATHON_*.

[everpeace]

Read command line options from MARATHON_* environment variables like meos-master/slave.

This could be very useful when you start marathon with docker. If we had a docker container in which marathon was installed and whose Dockerfile contains ENTRYPOINT ["/marathon-0.6.1/bin/start"], we can start marathon like this.

$ docker run \
    -e "MARATHON_master=zk://localhost:2181/mesos" \ 
    -e "MARATHON_zk=zk://localhost:2181/marathon" \
    marathon

However, I'm not a shell script expart, so I would be pleasure to have feedbacks.

[HelloGrayson]

+1

[HelloGrayson]

@everpeace it looks like mesos uses all caps for this, aka you should be doing something like so:

$ docker run \
    -e "MARATHON_MASTER=zk://localhost:2181/mesos" \ 
    -e "MARATHON_ZK=zk://localhost:2181/marathon" \
    marathon

[everpeace]

@breerly thanks for your feedback. I pushed a commit supporting environment variables with all CAP like MARATHON_ZK.

[ConnorDoyle]

@everpeace Hi Shingo, sorry for the delay on this. I'd love to get this landed for 0.7.4 (scheduled for 10 October). Could you describe this change in the docs as well?

[everpeace]

@ConnorDoyle Thanks for reviewing this. I rebased my branch and added

• supporting env variable also in service script 'marathon-framework', and
• paved 'command-line-flags.md' for this feature.

[ConnorDoyle]

Could we also describe which setting takes precedence when both are supplied?

[everpeace]

Yes, we should describe this. I will add this.

[everpeace]

@ConnorDoyle I forgot pinging you.

[everpeace]

@ConnorDoyle Thank you very much for your kind shepherding!

[ConnorDoyle]

Thanks Shingo!