[DCOS-58437] Deploy workloads under role-enforced group. #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpereira
changed the title
mpereira
force-pushed
the
dcos-58437-deploy-workloads-under-role-enforced-group
branch
from
1d8575d
to
510676e
Compare
samvantran
approved these changes
Oct 7, 2019
mpereira
force-pushed
the
dcos-58437-deploy-workloads-under-role-enforced-group
branch
from
955ff8d
to
f4a0d7d
Compare
mpereira
force-pushed
the
dcos-58437-deploy-workloads-under-role-enforced-group
branch
from
33907e2
to
d7235ac
Compare
|
@samvantran there were a bunch of additional changes/improvements required for a smooth test today, please take a look at commits after your last review if you get a chance. |
samvantran
approved these changes
Oct 10, 2019
alexeygorobets
force-pushed
the
dcos-58437-deploy-workloads-under-role-enforced-group
branch
from
440cd25
to
9f4b3cb
Compare
|
This PR changed Need to take a look into that... |
|
Looking at the 6 tests that fail towards the end of the CI run, it appears that |
| @@ -31,6 +31,7 @@ | |||
| --quota-executors-gpus <n> number of GPUs to use for executors quota [default: 0] | |||
| --quota-executors-mem <n> amount of memory (mb) to use per executors quota [default: 1524.0] | |||
| --role <role> Mesos role registered by dispatcher [default: *] | |||
| --group-role <group-role> TODO: description [default: None] | |||
There was a problem hiding this comment.
Maybe we should provide a description here
root-level group to apply quotas against (e.g. '/dev') [default: None] ?
Co-Authored-By: Sam Tran <stran@mesosphere.com>
rishabh96b
force-pushed
the
dcos-58437-deploy-workloads-under-role-enforced-group
branch
from
38bbbd2
to
275da0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Resolves DCOS-58437
How were these changes tested?
They will be tested in this week's Dry-Run MWT #21.