-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add publish-denoland workflow #64
Conversation
@jcbhmr I don't understand why we need this? 🤔 |
Because right now deno users are using the /src/index.ts in their code:
This change would publish a denoified version of this package which would allow users to use the I think we're leaning towards the second option of second-class as more of a "cool side-effect but not really the focus of this package". Is that right? If so, yes this workflow is redundant. |
@jcbhmr No you're right. I didn't realise that is_what needed to be used as per your screenshots in deno. This workflow causes no harm. I'd love to merge it. Some things you threw out of the Not sure we need all the extra crap on next, nuxt, gatsby, vitepress, since we won't use them for is-what. 😅 but ah well, it's just a gitignore file no one looks at |
Guess what! There's a well-defined standard workflow for those pesky
|
This PR requires the outDir option to be set in tsconfig.json and is therefore blocked by #74 |
Given that another month has passed, I think that the best way forward is just to say "use the npm: specifier" since it's become much much better over the past few months. You can now Thus, I think the right way to move forward is to NOT merge this and instead focus on making a good npm package. Deno |
This PR would...
Allows the removal of dist from the source tree! 🎉Actually this was me misunderstanding what deno users were doing