Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (#patch); euler-finance; fix for euler oneshot cancelled error #1213

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

tnkrxyz
Copy link
Collaborator

@tnkrxyz tnkrxyz commented Oct 17, 2022

Fix for euler "oneshot cancelled error" with minimal changes to current implementation.

The loop for (let i = 0; i < eulerViewMarkets.length; i += 1) in syncWithEulerGeneralView() of src/mappings/helper.ts is where the error occurs, and my tests found that these two lines are the last straw

    updateMarketDailyMetrics(block, market.id, BIGDECIMAL_ZERO);
    updateMarketHourlyMetrics(block, market.id, BIGDECIMAL_ZERO);

I removed these two lines in the function by swtiching the order of function calls in handler functions. My test deployment of the fix is working: https://thegraph.com/hosted-service/subgraph/tnkrxyz/euler?version=pending&selected=logs and a new test deployment with code in this PR is at: https://thegraph.com/hosted-service/subgraph/tnkrxyz/test-subgraph?version=pending

It'd be a good idea to merge #1212 first & rebase this PR before merging.

@tnkrxyz tnkrxyz requested a review from melotik October 17, 2022 03:23
@tnkrxyz
Copy link
Collaborator Author

tnkrxyz commented Oct 17, 2022

This PR will replace #1174

Copy link
Contributor

@melotik melotik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! I will let you rebase / merge, but I am going to approve rn.

Note: I am going to deploy this to messari's hosted service off of your branch to get this up and running. All that needs to be done is for this to be rebased/merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants