Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C API for TFIDF #61

Merged
merged 1 commit into from
Jul 8, 2019
Merged

C API for TFIDF #61

merged 1 commit into from
Jul 8, 2019

Conversation

MnO2
Copy link
Collaborator

@MnO2 MnO2 commented Jul 8, 2019

No description provided.

@codecov
Copy link

codecov bot commented Jul 8, 2019

Codecov Report

Merging #61 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #61   +/-   ##
======================================
  Coverage    86.4%   86.4%           
======================================
  Files           4       4           
  Lines         206     206           
======================================
  Hits          178     178           
  Misses         28      28
Impacted Files Coverage Δ
capi/src/lib.rs 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eda94c4...f9c3e51. Read the comment docs.

@messense messense merged commit d439233 into messense:master Jul 8, 2019
@messense
Copy link
Owner

messense commented Jul 8, 2019

On second thought, I think we should expand the API surface of TFIDF C API to allow reusing the TFIDF instance.

  • jieba_tfidf_new
  • jieba_tfidf_free
  • jieba_tfidf_extract

@MnO2 MnO2 mentioned this pull request Jul 8, 2019
15 tasks
@MnO2 MnO2 deleted the capi-tfidf branch July 14, 2019 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants