Feature/menu selection #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not really necessary to add an auto-increment ID to a pivot table
Handle specific exception during menu creation
Add a custom exception and test
faddai
added a commit
that referenced
this pull request
Nov 28, 2017
* develop: Feature/menu selection (#19)
faddai
added a commit
that referenced
this pull request
Nov 28, 2017
* Add code coverage report generation * Add feature to create a menu (#5) * add id to menu_items table * edit views for menu * persist menu to DB * fix validation * temporally remove actions * correct saturday fields * add migration to make serving field unqiue * mend migration * drop date column and recreate * clean up message and fix migration * obey psr2 🙏 * fix weekly restrictions * clean up action buttons * Get rid of migration It is not really necessary to add an auto-increment ID to a pivot table * Make serving_at unique without dropping the column * Add spacing between labels and dropdowns * bump up php version as requirement for Doctrine * fix menu tests * clean up menu view some more * adjust menu ui * set defaults for outputs * create a factory for MenuItems * add test for adding menu items * relief AddMenuJob of returning payload to next dispatch * adjust test to check for menu instance * persist menu items without menuItem model * delete MenuItem model * adjust test base on changes * fix typo * use AddMenuJob for item addition * modify test accordingly * change incoming meal structure and validation * refactor validation * adjust test accordingly * Add a generic error message for validation errors * Clean up * Get rid of temporary variable * Feature/menu selection (#19) * add id to menu_items table * edit views for menu * persist menu to DB * fix validation * temporally remove actions * correct saturday fields * add migration to make serving field unqiue * mend migration * drop date column and recreate * clean up message and fix migration * obey psr2 🙏 * fix weekly restrictions * clean up action buttons * Get rid of migration It is not really necessary to add an auto-increment ID to a pivot table * Make serving_at unique without dropping the column * Add spacing between labels and dropdowns * bump up php version as requirement for Doctrine * fix menu tests * clean up menu view some more * adjust menu ui * set defaults for outputs * create a factory for MenuItems * add test for adding menu items * relief AddMenuJob of returning payload to next dispatch * adjust test to check for menu instance * persist menu items without menuItem model * delete MenuItem model * adjust test base on changes * fix typo * add menu selection * add time restriction to selections * change date to datetime to allow for selection based on dates over flags * adjust test accordingly * fix Exception Handler * fix single insertion * use AddMenuJob for item addition * modify test accordingly * remove menu selection * adjust test * fix validation * adjust days * add exception * change dummy date to actual date * Add all configs in config/mkoo.php * Fix validation to require meal ids Handle specific exception during menu creation * Refactor AddMenuJob Add a custom exception and test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues #9 #18 NB : this PR is based on #5 Changes for this starts from here