Revert "Fix missing result metadata (#39201) (#39243)"

This reverts commit ca5d0e2.

e2e/support/helpers/e2e-misc-helpers.js

@@ -40,15 +40,6 @@ export function openNativeEditor({
   return cy.findByTestId("native-query-editor").as(alias).should("be.visible");
 }
 
-export function focusNativeEditor() {
-  return cy
-    .findByTestId("native-query-editor")
-    .should("be.visible")
-    .should("have.class", "ace_editor")
-    .click()
-    .should("have.class", "ace_focus");
-}
-
 /**
  * Executes native query and waits for the results to load.
  * Makes sure that the question is not "dirty" after the query successfully ran.

frontend/src/metabase/query_builder/actions/core/core.js

@@ -30,11 +30,11 @@ import {
   getCard,
   getIsResultDirty,
   getOriginalQuestion,
-  getParameters,
   getQuestion,
   getResultsMetadata,
   getTransformedSeries,
   isBasedOnExistingQuestion,
+  getParameters,
 } from "../../selectors";
 import { updateUrl } from "../navigation";
 import { zoomInRow } from "../object-detail";
@@ -248,17 +248,10 @@ export const apiUpdateQuestion = (question, { rerunQuery } = {}) => {
     const originalQuestion = getOriginalQuestion(getState());
     question = question || getQuestion(getState());
 
-    let resultsMetadata = getResultsMetadata(getState());
+    const resultsMetadata = getResultsMetadata(getState());
     const isResultDirty = getIsResultDirty(getState());
 
     if (question.isDataset()) {
-      if (!resultsMetadata) {
-        // Running the question will populate results metadata in redux store.
-        // Without it getSubmittableQuestion won't have all the necessary information.
-        await dispatch(runQuestionQuery());
-        resultsMetadata = getResultsMetadata(getState());
-      }
-
       resultsMetadata.columns = ModelIndexes.actions.cleanIndexFlags(
         resultsMetadata.columns,
       );

frontend/src/metabase/query_builder/actions/querying.js

@@ -121,7 +121,7 @@ export const runQuestionQuery = ({
 
     const queryTimer = startTimer();
 
-    const runQuestionPromise = apiRunQuestionQuery(question, {
+    apiRunQuestionQuery(question, {
       cancelDeferred: cancelQueryDeferred,
       ignoreCache: ignoreCache,
       isDirty: cardIsDirty,
@@ -140,8 +140,6 @@ export const runQuestionQuery = ({
       .catch(error => dispatch(queryErrored(startTime, error)));
 
     dispatch({ type: RUN_QUERY, payload: { cancelQueryDeferred } });
-
-    return runQuestionPromise;
   };
 };