🤖 backported "Fix missing result metadata" #39243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![metabase-bot[bot]](https://avatars.githubusercontent.com/in/220029?s=60&v=4){kind=small}
metabase-bot
bot
added
the
was-backported
kamilmielnik
force-pushed
the
backport-d26b7820639faa15acb8d7a50429230d67d58c27
branch
from
735a420
to
42a58fe
Compare
* Keep result-metadata of native queries if possible Part of #37009. * Fix typo * Add a fallback for when resultMetadata is not available * Revert "Add a fallback for when resultMetadata is not available" This reverts commit 5ad3a8b. * Move resultsMetadata logic into getSubmittableQuestion * Add a fallback for when resultMetadata is not available * Add explanatory comment * Guard against missing resultsMetadata * Add repro for #35039 * Simplify the test * Add an explanatory comment * Fix test * Rename promise to runQuestionPromise --------- Co-authored-by: Tamás Benkő <tamas@metabase.com>
kamilmielnik
force-pushed
the
backport-d26b7820639faa15acb8d7a50429230d67d58c27
branch
from
42a58fe
to
0faf30f
Compare
kamilmielnik
approved these changes
Feb 28, 2024
|
kamilmielnik
deleted the
backport-d26b7820639faa15acb8d7a50429230d67d58c27
branch
kamilmielnik
added a commit
that referenced
this pull request
Feb 29, 2024
kamilmielnik
added a commit
that referenced
this pull request
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#39201
Important
Manual conflict resolution is required.
Checkout the branch and run
./backport.shscript. Force push your changes after cherry-picking.