Fix missing result metadata #39201
Merged
Fix missing result metadata #39201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5ad3a8b.
kamilmielnik
commented
Feb 27, 2024
Comment on lines
1063
to
1067
| if (question.type() === "model") { | ||
| resultsMetadata.columns = ModelIndexes.actions.cleanIndexFlags( | ||
| resultsMetadata.columns, | ||
| ); | ||
| } |
There was a problem hiding this comment.
This part should have been moved in #39147.
It worked without moving because it mutates (!) data in redux store.
kamilmielnik
changed the title
kamilmielnik
added
the
backport
|
kamilmielnik
changed the title
Base automatically changed from
37009-keep-native-question-result-metadata
to
master
February 27, 2024 15:30
uladzimirdev
approved these changes
Feb 28, 2024
|
@kamilmielnik Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
kamilmielnik
added a commit
that referenced
this pull request
Feb 28, 2024
* Keep result-metadata of native queries if possible Part of #37009. * Fix typo * Add a fallback for when resultMetadata is not available * Revert "Add a fallback for when resultMetadata is not available" This reverts commit 5ad3a8b. * Move resultsMetadata logic into getSubmittableQuestion * Add a fallback for when resultMetadata is not available * Add explanatory comment * Guard against missing resultsMetadata * Add repro for #35039 * Simplify the test * Add an explanatory comment * Fix test * Rename promise to runQuestionPromise --------- Co-authored-by: Tamás Benkő <tamas@metabase.com>
kamilmielnik
added a commit
that referenced
this pull request
Feb 28, 2024
* Keep result-metadata of native queries if possible Part of #37009. * Fix typo * Add a fallback for when resultMetadata is not available * Revert "Add a fallback for when resultMetadata is not available" This reverts commit 5ad3a8b. * Move resultsMetadata logic into getSubmittableQuestion * Add a fallback for when resultMetadata is not available * Add explanatory comment * Guard against missing resultsMetadata * Add repro for #35039 * Simplify the test * Add an explanatory comment * Fix test * Rename promise to runQuestionPromise --------- Co-authored-by: Tamás Benkő <tamas@metabase.com>
kamilmielnik
added a commit
that referenced
this pull request
Feb 28, 2024
* Keep result-metadata of native queries if possible Part of #37009. * Fix typo * Add a fallback for when resultMetadata is not available * Revert "Add a fallback for when resultMetadata is not available" This reverts commit 5ad3a8b. * Move resultsMetadata logic into getSubmittableQuestion * Add a fallback for when resultMetadata is not available * Add explanatory comment * Guard against missing resultsMetadata * Add repro for #35039 * Simplify the test * Add an explanatory comment * Fix test * Rename promise to runQuestionPromise --------- Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com> Co-authored-by: Tamás Benkő <tamas@metabase.com>
kamilmielnik
added a commit
that referenced
this pull request
Feb 29, 2024
kamilmielnik
added a commit
that referenced
this pull request
Feb 29, 2024
This reverts commit d26b782.
kamilmielnik
added a commit
that referenced
this pull request
Mar 1, 2024
kamilmielnik
added a commit
that referenced
this pull request
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37009
Fixes #35039
Depends on #39184
Description
Backend won't give us
card.result_metadatawhen query executes for longer than 1.5 s - see PR description for explanation (and Slack discussion). In this case FE needs to explicitly run the query to get this information.How to verify
Follow reproduction steps from #37009 or #35039 (comment).
Tests are all green.
Stress test for new e2e test passes: https://github.com/metabase/metabase/actions/runs/8079345130