Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bar chart doesn't handle null data well #12138

Closed
CaliLuke opened this issue Mar 16, 2020 · 3 comments
Closed

Bar chart doesn't handle null data well #12138

CaliLuke opened this issue Mar 16, 2020 · 3 comments
Assignees
Labels
.Correctness Priority:P2 Average run of the mill bug Type:Bug Product defects Visualization/Charts Line, area, bar, combo, and scatter charts.
Milestone

Comments

@CaliLuke
Copy link

Is your feature request related to a problem? Please describe.

Currently when displaying data with categorical labels, the bar chart doesn't have a way to either add a "null" category or remove it from display.

Describe the solution you'd like

Add a "null" category by default, and allow users to hide it or show it.

Describe alternatives you've considered

we could filter the values but the visualizations should be robust to a very common data issue.

How important is this feature to you?

very, it breaks most visualizations containing null data

Additional context

2020-03-16_14-43-16

2020-03-16_14-41-31

@flamber
Copy link
Contributor

flamber commented Mar 16, 2020

When using binning/granularity "Minute of hour" or "Hour of day", then null is added incorrectly to the first column of Line/Bar/Area chart.
There's a warning triangle "column" is an unaggregated field: if it has more than one value at a point on the x-axis, the values will be summed., but that's incorrect in this case.
And displaying with data points causes it to show double points for the first column.
image

Displaying as Row chart will correctly add null to a special "(empty)" bar - and it doesn't show a triangle, but that might be because of #12655:
image

Related to #11907

@flamber flamber added .Correctness Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Type:Bug Product defects Visualization/Charts Line, area, bar, combo, and scatter charts. and removed .Need More Info Type:New Feature labels Jun 6, 2020
@flamber flamber added Priority:P2 Average run of the mill bug and removed Priority:P3 Cosmetic bugs, minor bugs with a clear workaround labels Mar 21, 2021
@alxnddr
Copy link
Member

alxnddr commented Apr 8, 2021

The same happens when the X axis is a numeric column that contains both 0 and null:
Screen Shot 2021-04-09 at 01 13 54

This is happening because of a bug in the crossfilter dependency
crossfilter/crossfilter#164

@alxnddr
Copy link
Member

alxnddr commented Apr 12, 2021

Fixed by #15554

Repro is needed, I will add in a separate PR

This was referenced May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Correctness Priority:P2 Average run of the mill bug Type:Bug Product defects Visualization/Charts Line, area, bar, combo, and scatter charts.
Projects
None yet
Development

No branches or pull requests

3 participants