Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Human-reable numering not working properly #12629

Closed
vvaezian opened this issue Jun 1, 2020 · 1 comment
Closed

Human-reable numering not working properly #12629

vvaezian opened this issue Jun 1, 2020 · 1 comment
Assignees
@howonlee
Labels
Customization/Formatting Priority:P2 Average run of the mill bug .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Reporting/Dashboards .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects Visualization/Chart Settings Visualization/Scalars Numbers, progress bars, gauges
Projects
Cypress Testing
Milestone
0.39.4

Comments

@vvaezian
Copy link

vvaezian commented Jun 1, 2020

This is regarding the issue reported here.
On desktop (checked on Firefox and Chrome) if the browser width is bigger than a certain threshold, big numbers are not shown in human-readable format.

big numbers

It still doesn't work on mobile either (although in the issue mentioned above there is a comment that says "Fixed in #10932")

Metabase Version: v0.35.4 (the issue occurs with previous versions as well)
@vvaezian vvaezian added .Needs Triage Type:Bug Product defects labels Jun 1, 2020
@flamber flamber added Customization/Formatting Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Reporting/Dashboards Priority:P2 Average run of the mill bug and removed .Needs Triage Priority:P3 Cosmetic bugs, minor bugs with a clear workaround labels Jun 1, 2020
@flamber
Copy link
Contributor

flamber commented Jun 1, 2020 •
edited

Hi @vvaezian - sorry for the overlook in #10716 (compact numbers rounding)
Looks like the "humanized" format was broken. Overflow might be #4648 in general
Someone created an issue on it, but I misunderstood it as a request to use a specific library - #12057
Related to #3321 and #6201 and #7039

Steps to reproduce:

  1. Native query > Sample Dataset > select 1234567890123456 save as "Q1"
  2. Add "Q1" three times to a dashboard with card sizes 3x3, 4x4 and 5x5
  3. View in different viewports/resolutions
    1. 1920:
      image
    2. 1600:
      image
    3. 1200:
      image
    4. 960:
      image
    5. 400:
      image

@flamber flamber mentioned this issue Aug 21, 2020
Closed
@flamber flamber added the .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. label Jan 29, 2021
nemanjaglumac added a commit that referenced this issue May 25, 2021
@nemanjaglumac
Add repro for #12629
729d117
@nemanjaglumac nemanjaglumac mentioned this issue May 25, 2021
Merged
nemanjaglumac added a commit that referenced this issue Jun 1, 2021
@nemanjaglumac
#12629 Repro: Human-readable number formatting not working properly (#…
76c2bc2 
…16231)
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Jun 1, 2021
@howonlee howonlee self-assigned this Jun 9, 2021
@howonlee howonlee mentioned this issue Jun 9, 2021
Merged
@flamber flamber added this to the 0.39.4 milestone Jun 14, 2021
@flamber flamber closed this as completed Jun 14, 2021
nemanjaglumac added a commit that referenced this issue Jun 15, 2021
@nemanjaglumac @jeff303
@camsaul @paulrosenzweig @noahmoss
Merge release-x.39.x including ae6e9d9 (#16575)
835fba8 
* Cleanup from dump-load-entities-test (#16281)

Updating dump-load-entities-test test so that dump dir is actually deleted at the end

* Revamp Cypress custom commands (#16292)

* Extract UI custom commands

* Extract user related custom commands

* Extract overwrites

* Extract permissions related custom commands

* Extract API custom commands

* Extract helpers custom commands

* Extract database related custom commands

* Rename `helpers` group to `visibility`

* Rename custom command `isInViewport` to `isRenderedWithinViewport`

* Unskip repro for #15119 (#16297)

* Create composite Cypress custom command `cy.createQuestionAndDashboard` (#16294)

* Add composite Cypress custom command `createQuestionAndDashboard`

* Refactor the existing test to use new Cypress custom command

* Refactor repro for #13062 using the new Cypress custom command

* Use the `describe` block instead of using `forEach` for complex repro

* Add space between test cases

* #12629 Repro: Human-readable number formatting not working properly (#16231)

* Fix `nosql` user's email address (#16306)

* Generate correct SQL for columns from joins inside other joins or source queries (#16254)

* Fix joining a join inside a nested queries (#12928)

* Code cleanup & dox

* Tests for #13649

* Test fixes 🔧

* Remove unit tests snapshots (#16321)

* Remove snapshots from `Calendar.unit.spec.js`

* Remove snapshots from `DashCard.unit.spec.js`

* Remove snapshots generated for "internal" components

* Remove unused import

* Remove snapshot related command from `scripts`

* Remove `noSnapshotTest` from internal components

* Remove `react-test-renderer`

* filter nulls out of histograms (#16345)

* #15993 Repro: Click behavior with filter pass-thru does not show filters defined on question (#16342)

* #16334 Repro: Click Behavior targeting a question with filter mapped causes the visualization type to change (#16343)

* Add repro for #16334

* Expand test assertion

* #16327 Repro: Double binning menu for date fields when using Saved Question (Native) (#16359)

* #16322 Repro: "Custom mapping" is only available, when "A list of all values" is set (and after a browser refresh) (#16361)

* #16226 Repro: LDAP/Email settings gets cleared if validation fails (#16364)

* Add repro for #16226

* Extract email settings into a separate file

* Add repro for #16226 (Email)

* switch to column settings when sidebar is already open (#16368)

* align labels on non-bars in combo charts (#16369)

* #16378 Repro: Cannot enable JWT authentication (#16384)

* Fix JS error on JWT settings form (#16394)

* fix default updateSettings function in SettingsBatchForm

* unskip repro

* #12128 Repro: Can't change label on empty row value (#16426)

* Post-merge fix

* Post-merge fix 2
I didn't solve this merge conflict properly in the original merge.

Co-authored-by: Jeff Evans <jeff303@users.noreply.github.com>
Co-authored-by: Cam Saul <1455846+camsaul@users.noreply.github.com>
Co-authored-by: Paul Rosenzweig <paulrosenzweig@users.noreply.github.com>
Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
@flamber flamber mentioned this issue Jun 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@howonlee howonlee

Labels
Customization/Formatting Priority:P2 Average run of the mill bug .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Reporting/Dashboards .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects Visualization/Chart Settings Visualization/Scalars Numbers, progress bars, gauges
Projects
Cypress Testing
Awaiting triage
Milestone
0.39.4
Development

No branches or pull requests
4 participants
@howonlee @flamber @vvaezian @nemanjaglumac