Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double binning menu for date fields when using Saved Question (Native) #16327

Closed
flamber opened this issue Jun 2, 2021 · 2 comments · Fixed by #16755
Closed

Double binning menu for date fields when using Saved Question (Native) #16327

flamber opened this issue Jun 2, 2021 · 2 comments · Fixed by #16755
Assignees
@ariya
Labels
Difficulty:Easy .Frontend Priority:P2 Average run of the mill bug Querying/GUI Query builder catch-all, including simple mode Querying/Native The SQL/native query editor Querying/Nested Queries Questions based on other saved questions .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone
0.40

Comments

@flamber
Copy link
Contributor

flamber commented Jun 2, 2021 •
edited

Describe the bug
This is a reprise of #15446, but specific to when base is a Native question.

To Reproduce

  1. Native query > Sample Dataset > select * from products - save as "Q1"
  2. Custom question > Saved Questions > "Q1"
  3. Summarize Count by CreatedAt - click the binning menu, notice all options are duplicated (upper and lower).
    Selecting any of the options in the upper-part will be dropped when clicking Visualize (similar to Incorrect result + loss of user input when summarizing with Saved Question #15725)
    Had to zoom out a bit to completely show all options.
    image
  4. Select one of the options from the lower-part and click Visualize
    image
  5. On Simple view, it does not mark which option is selected, but also here only the lower-part of options should be used.
    Selecting any of the options in the upper-part will cause the same problem as The query builder seems to be dropping field type information from aggregate columns in nested questions if you use the summarize sidebar #15397/Incorrect result + loss of user input when summarizing with Saved Question #15725
    image

Information about your Metabase Installation:
Tested 0.38.4 thru 0.39.3 - regression since 0.39.0

⬇️ Please click the 👍 reaction instead of leaving a +1 or update? comment
@flamber flamber added Type:Bug Product defects Priority:P2 Average run of the mill bug Querying/Native The SQL/native query editor Querying/Nested Queries Questions based on other saved questions .Frontend Querying/GUI Query builder catch-all, including simple mode .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. labels Jun 2, 2021
@flamber flamber mentioned this issue Jun 2, 2021
Closed
@ariya ariya self-assigned this Jun 2, 2021
nemanjaglumac added a commit that referenced this issue Jun 4, 2021
@nemanjaglumac
Add repro for #16327
901a091
@nemanjaglumac nemanjaglumac mentioned this issue Jun 4, 2021
Merged
nemanjaglumac added a commit that referenced this issue Jun 4, 2021
@nemanjaglumac
#16327 Repro: Double binning menu for date fields when using Saved Qu…
9404edb 
…estion (Native) (#16359)
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Jun 4, 2021
@ariya ariya mentioned this issue Jun 5, 2021
Closed
@flamber flamber mentioned this issue Jun 7, 2021
Closed
@nemanjaglumac nemanjaglumac mentioned this issue Jun 7, 2021
Open
12 tasks
nemanjaglumac added a commit that referenced this issue Jun 15, 2021
@nemanjaglumac @jeff303
@camsaul @paulrosenzweig @noahmoss
Merge release-x.39.x including ae6e9d9 (#16575)
835fba8 
* Cleanup from dump-load-entities-test (#16281)

Updating dump-load-entities-test test so that dump dir is actually deleted at the end

* Revamp Cypress custom commands (#16292)

* Extract UI custom commands

* Extract user related custom commands

* Extract overwrites

* Extract permissions related custom commands

* Extract API custom commands

* Extract helpers custom commands

* Extract database related custom commands

* Rename `helpers` group to `visibility`

* Rename custom command `isInViewport` to `isRenderedWithinViewport`

* Unskip repro for #15119 (#16297)

* Create composite Cypress custom command `cy.createQuestionAndDashboard` (#16294)

* Add composite Cypress custom command `createQuestionAndDashboard`

* Refactor the existing test to use new Cypress custom command

* Refactor repro for #13062 using the new Cypress custom command

* Use the `describe` block instead of using `forEach` for complex repro

* Add space between test cases

* #12629 Repro: Human-readable number formatting not working properly (#16231)

* Fix `nosql` user's email address (#16306)

* Generate correct SQL for columns from joins inside other joins or source queries (#16254)

* Fix joining a join inside a nested queries (#12928)

* Code cleanup & dox

* Tests for #13649

* Test fixes 🔧

* Remove unit tests snapshots (#16321)

* Remove snapshots from `Calendar.unit.spec.js`

* Remove snapshots from `DashCard.unit.spec.js`

* Remove snapshots generated for "internal" components

* Remove unused import

* Remove snapshot related command from `scripts`

* Remove `noSnapshotTest` from internal components

* Remove `react-test-renderer`

* filter nulls out of histograms (#16345)

* #15993 Repro: Click behavior with filter pass-thru does not show filters defined on question (#16342)

* #16334 Repro: Click Behavior targeting a question with filter mapped causes the visualization type to change (#16343)

* Add repro for #16334

* Expand test assertion

* #16327 Repro: Double binning menu for date fields when using Saved Question (Native) (#16359)

* #16322 Repro: "Custom mapping" is only available, when "A list of all values" is set (and after a browser refresh) (#16361)

* #16226 Repro: LDAP/Email settings gets cleared if validation fails (#16364)

* Add repro for #16226

* Extract email settings into a separate file

* Add repro for #16226 (Email)

* switch to column settings when sidebar is already open (#16368)

* align labels on non-bars in combo charts (#16369)

* #16378 Repro: Cannot enable JWT authentication (#16384)

* Fix JS error on JWT settings form (#16394)

* fix default updateSettings function in SettingsBatchForm

* unskip repro

* #12128 Repro: Can't change label on empty row value (#16426)

* Post-merge fix

* Post-merge fix 2
I didn't solve this merge conflict properly in the original merge.

Co-authored-by: Jeff Evans <jeff303@users.noreply.github.com>
Co-authored-by: Cam Saul <1455846+camsaul@users.noreply.github.com>
Co-authored-by: Paul Rosenzweig <paulrosenzweig@users.noreply.github.com>
Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
@flamber flamber mentioned this issue Jun 16, 2021
Closed
@gvaibhavraj2

This comment has been minimized.

Sign in to view
@flamber

This comment has been minimized.

Sign in to view
@ariya ariya mentioned this issue Jun 24, 2021
Merged
@flamber flamber added this to the 0.40 milestone Jun 25, 2021
This was referenced Dec 12, 2022
Merged
Merged
@deploysentinel deploysentinel bot mentioned this issue Feb 10, 2023
Closed
@deploysentinel deploysentinel bot mentioned this issue Mar 16, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue Mar 31, 2023
Closed
@deploysentinel deploysentinel bot mentioned this issue Apr 11, 2023
Draft
This was referenced Apr 30, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Open
Open
Open
Merged
Open
Open
Open
Draft
Open
Open
Merged
Merged
Open
Merged
Open
Merged
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ariya ariya

Labels
Difficulty:Easy .Frontend Priority:P2 Average run of the mill bug Querying/GUI Query builder catch-all, including simple mode Querying/Native The SQL/native query editor Querying/Nested Queries Questions based on other saved questions .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Milestone
0.40
Development

Successfully merging a pull request may close this issue.

Fix duplicated temporal subdimensions metabase/metabase
4 participants
@ariya @flamber @gvaibhavraj2 @nemanjaglumac