Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI should trim whitespace from "Host" field when adding a new database #12972

Closed
max-rocket-internet opened this issue Jul 22, 2020 · 1 comment · Fixed by #14594
Closed

UI should trim whitespace from "Host" field when adding a new database #12972

max-rocket-internet opened this issue Jul 22, 2020 · 1 comment · Fixed by #14594
Assignees
Labels
Priority:P3 Cosmetic bugs, minor bugs with a clear workaround .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone

Comments

@max-rocket-internet
Copy link

Describe the bug

Whitespace is not trimmed from UI filed Host when adding a new database causing a connection error if there is a trailing space/tab.

Logs

Not required.

To Reproduce
Steps to reproduce the behavior:

Add a new database in the UI with a trailing space, like my-app.cluster-ro-xxxxxxxxxx.eu-west-1.rds.amazonaws.com

Expected behavior

UI should trim whitespace.

Information about your Metabase Installation:

You can get this information by going to Admin -> Troubleshooting.

{
  "browser-info": {
    "language": "en-GB",
    "platform": "MacIntel",
    "userAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.116 Safari/537.36",
    "vendor": "Google Inc."
  },
  "system-info": {
    "file.encoding": "UTF-8",
    "java.runtime.name": "OpenJDK Runtime Environment",
    "java.runtime.version": "11.0.5+10",
    "java.vendor": "AdoptOpenJDK",
    "java.vendor.url": "https://adoptopenjdk.net/",
    "java.version": "11.0.5",
    "java.vm.name": "OpenJDK 64-Bit Server VM",
    "java.vm.version": "11.0.5+10",
    "os.name": "Linux",
    "os.version": "4.14.177-139.253.amzn2.x86_64",
    "user.language": "en",
    "user.timezone": "UTC"
  },
  "metabase-info": {
    "databases": [
      "postgres",
      "mysql"
    ],
    "hosting-env": "unknown",
    "application-database": "postgres",
    "application-database-details": {
      "database": {
        "name": "PostgreSQL",
        "version": "9.6.16"
      },
      "jdbc-driver": {
        "name": "PostgreSQL JDBC Driver",
        "version": "42.2.8"
      }
    },
    "run-mode": "prod",
    "version": {
      "date": "2020-04-02",
      "tag": "v0.35.1",
      "branch": "release-0.35.x",
      "hash": "e67f169"
    },
    "settings": {
      "report-timezone": null
    }
  }
}

Severity

Minor

@flamber flamber added Admin Panel & Setup Priority:P3 Cosmetic bugs, minor bugs with a clear workaround and removed .Needs Triage labels Jul 22, 2020
@flamber
Copy link
Contributor

flamber commented Jul 22, 2020

Related to #9836

@daltojohnso daltojohnso self-assigned this Jan 28, 2021
@flamber flamber added this to the 0.39 milestone Feb 8, 2021
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Oct 3, 2022
This was referenced May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:P3 Cosmetic bugs, minor bugs with a clear workaround .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants