Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Questions based on Saved Question joined with another Saved Question breaks Notebook #13000

Closed
flamber opened this issue Jul 26, 2020 · 0 comments · Fixed by #12997
Closed

Questions based on Saved Question joined with another Saved Question breaks Notebook #13000

flamber opened this issue Jul 26, 2020 · 0 comments · Fixed by #12997
Labels
.Frontend Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/Nested Queries Questions based on other saved questions Querying/Notebook Items specific to the Custom/Notebook query builder .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone
0.36.1

Comments

@flamber
Copy link
Contributor

flamber commented Jul 26, 2020

Describe the bug
Questions that is based on a Saved Question, and has a join with another Saved Question, causes the Notebook editor to fail (breaks UI) for existing questions.

To Reproduce

  1. Simple question > Sample Dataset > Orders > "Sum of Total" group by ProductID - save as "Q1"
    image
  2. Simple question > Sample Dataset > Products > "Sum of Rating" group by ID - save as "Q2"
    image
  3. Custom question > Saved Questions > "Q1" join "Q2" on ProductID=ID
    image
    This isn't even possible to do in 0.36.0, but if it is done in 0.35.4 and question saved as "Q3", and then starting 0.36.0 to visit "Q3", then it's not possible to enter Notebook.
    Browser console errors with Uncaught TypeError: setting getter-only property "filter_operators" (Firefox) or Uncaught TypeError: Cannot set property filter_operators of #<Field> which has only a getter (Chromium)

Information about your Metabase Installation:
Metabase 0.36.0 - this used to work in 0.35.4
@flamber flamber added Type:Bug Product defects Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/Nested Queries Questions based on other saved questions .Frontend Querying/Notebook Items specific to the Custom/Notebook query builder labels Jul 26, 2020
@flamber flamber added this to the 0.36.1 milestone Jul 26, 2020
@flamber flamber linked a pull request Jul 26, 2020 that will close this issue
don't set filter_operators when creating field literals' fake fields #12997
Merged
@flamber flamber closed this as completed Jul 27, 2020
@Opalevanescence Opalevanescence added this to Issues to Test in Cypress Testing Jul 27, 2020
nemanjaglumac pushed a commit that referenced this issue Sep 24, 2020
Add repro for #13000
e448dd5
@nemanjaglumac nemanjaglumac mentioned this issue Sep 24, 2020
Merged
@nemanjaglumac nemanjaglumac moved this from Issues to Test to Fixed and Checked (Issue) in Cypress Testing Sep 24, 2020
nemanjaglumac added a commit that referenced this issue Sep 28, 2020
@nemanjaglumac
Repro for #13000 (#13307)
26afdcb 
* Add repro for #13000

* Improve test with added log and assertion

* Refactor the test to avoid flakiness

- it was failing in CI:
	1. finding multiple "Product IDs"
	2. XHR event "@card" never originated (locally, the card ID is 6, but in CI it seems it is 8, from what I can see in a video)
	(replacing hard coded ID `6` with a wildcard `*`)
- wrote a different flow so I don't have to remove pre-selected "Count" after I add "Sum of ..."
- added mid-point assertions on generated titles
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Oct 1, 2020
@nemanjaglumac nemanjaglumac mentioned this issue Nov 13, 2020
Merged
nemanjaglumac added a commit that referenced this issue Nov 13, 2020
@nemanjaglumac
Refactor Cypress repro for #13000
f9021da
@nemanjaglumac nemanjaglumac mentioned this issue Nov 13, 2020
Closed
nemanjaglumac added a commit that referenced this issue Nov 16, 2020
@nemanjaglumac
Refactor Cypress repro for #13000 (#13789)
80c89bf 
* Refactors an original repro for #13000 to use API instead of "clicking" around UI.
* Shortens the time to run this test from an average of ~20s to a bit less than ~3s
nemanjaglumac added a commit that referenced this issue Nov 16, 2020
@nemanjaglumac
Extract repro steps for #13000 into a helper function [ci skip]
5567062
nemanjaglumac added a commit that referenced this issue Nov 17, 2020
@nemanjaglumac
#13649 Repro: Custom column from joined questions (#13813)
23fe805 
* Restore before each test

* Extract repro steps for #13000 into a helper function

* Add repro for #13649
This was referenced Nov 21, 2022
Closed
Merged
Merged
Merged
Closed
Merged
Merged
@deploysentinel deploysentinel bot mentioned this issue Nov 28, 2022
Open
This was referenced May 8, 2024
Closed
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
.Frontend Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/Nested Queries Questions based on other saved questions Querying/Notebook Items specific to the Custom/Notebook query builder .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Milestone
0.36.1
Development

Successfully merging a pull request may close this issue.

don't set filter_operators when creating field literals' fake fields metabase/metabase
2 participants
@flamber @nemanjaglumac