Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Model page busted if you visit a database that doesn't exist #14652

Closed
camsaul opened this issue Feb 4, 2021 · 1 comment · Fixed by #16694
Closed

Data Model page busted if you visit a database that doesn't exist #14652

camsaul opened this issue Feb 4, 2021 · 1 comment · Fixed by #16694
Assignees
@kulyk
Labels
Administration/Table Metadata .Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Type:Bug Product defects
Milestone
0.40

Comments

@camsaul
Copy link
Member

camsaul commented Feb 4, 2021 •
edited

Probably an edge case, but we should make sure pages don't look insane if there isn't anything to display. It seems like it's not handling 404 (or other error) responses from the backend correctly.

image

Steps to repro

  1. Visit data model page in admin panel
  2. Delete the database from the REPL or another tab
  3. Hit refresh on data model page
  4. B R O K E N
@camsaul camsaul added Type:Bug Product defects .Needs Triage labels Feb 4, 2021
@camsaul camsaul changed the title Data Model page busted if there are no databases Data Model page busted if you visit a database that doesn't exist Feb 4, 2021
@flamber flamber added Administration/Table Metadata Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Type:UX Type:Bug Product defects .Frontend and removed .Needs Triage Type:Bug Product defects Type:UX labels Feb 4, 2021
@flamber
Copy link
Contributor

flamber commented Feb 4, 2021

Related to #11037

@kulyk kulyk self-assigned this Jun 21, 2021
kulyk added a commit that referenced this issue Jun 21, 2021
@kulyk
Add repro for #14652
db83a6a
@kulyk kulyk mentioned this issue Jun 21, 2021
Merged
kulyk added a commit that referenced this issue Jun 22, 2021
@kulyk
Fix Data Model page blank if database doesn't exist (#16694)
1a5a69b 
* Add repro for #14652

* Fix blank screen when DB does not exist

DataSelector assumes `schemas` is an array.
But it's `undefined` if db does not exist

* Fix data model page state when DB does not exist

* Move prop-types to the top

* Fix invalid database request
@flamber flamber added this to the 0.40 milestone Jun 22, 2021
@deploysentinel deploysentinel bot mentioned this issue Jan 29, 2023
Closed
@deploysentinel deploysentinel bot mentioned this issue Mar 10, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue Mar 20, 2023
Merged
This was referenced Apr 21, 2023
Merged
Merged
Merged
This was referenced Jan 11, 2024
Merged
Merged
Merged
Merged
Merged
Draft
This was referenced Feb 5, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Apr 4, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kulyk kulyk

Labels
Administration/Table Metadata .Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Type:Bug Product defects
Projects
None yet
Milestone
0.40
Development

Successfully merging a pull request may close this issue.

Fix Data Model page blank if database doesn't exist metabase/metabase
3 participants
@flamber @camsaul @kulyk