Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negative filter can not be converted to custom expression #14880

Closed
Tracked by #21485
ariya opened this issue Feb 18, 2021 · 2 comments
Closed
Tracked by #21485

Negative filter can not be converted to custom expression #14880

ariya opened this issue Feb 18, 2021 · 2 comments
Assignees
@ariya
Labels
Priority:P2 Average run of the mill bug Querying/GUI Query builder catch-all, including simple mode .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
Cypress Testing
Milestone
0.39

Comments

@ariya
Copy link
Contributor

ariya commented Feb 18, 2021

Steps to reproduce:

  1. Ask a question, Simple question
  2. Sample Dataset, Products
  3. Filter, Filter by Title
  4. Choose "Does not contain", type Wallet, press Add Filter
  5. Click on the new filter "Title does not contain Wallet"
  6. Press the left chevron icon, choose Custom Expression

Actual

Nothing happens, but the JavaScript console shows an error:

Unknown MBQL clause ["does-not-contain",["field-id",12],"Wallet",{"case-sensitive":false}]

image

Expected

The filter gets converted to something like NOT contains([Title], "Wallet").

Additional Note

This problem applies to another negative filter, e.g. "Not empty".

Note that a positive filter, such as "Title contains Wallet" will be correctly converted to a filter, i.e.:

contains([Title], "Wallet")
@ariya ariya added Type:Bug Product defects .Needs Triage labels Feb 18, 2021
@ariya ariya self-assigned this Feb 18, 2021
@nemanjaglumac nemanjaglumac added this to Backlog in Cypress Testing Feb 18, 2021
nemanjaglumac added a commit that referenced this issue Feb 19, 2021
@nemanjaglumac
Add repro for #14880 [ci skip]
af1fe1a
@nemanjaglumac nemanjaglumac mentioned this issue Feb 19, 2021
Merged
@ariya ariya mentioned this issue Feb 19, 2021
Merged
@flamber flamber added Priority:P2 Average run of the mill bug Querying/GUI Query builder catch-all, including simple mode and removed .Needs Triage labels Feb 19, 2021
@flamber
Copy link
Contributor

flamber commented Feb 19, 2021

Related to #12225

nemanjaglumac added a commit that referenced this issue Feb 19, 2021
@nemanjaglumac
#14880 Repro: Negative filter can not be converted to custom expressi…
2b309fe 
…on [ci skip] (#14885)
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Feb 19, 2021
ariya pushed a commit that referenced this issue Feb 23, 2021
@nemanjaglumac @ariya
#14880 Repro: Negative filter can not be converted to custom expressi…
b8ee088 
…on [ci skip] (#14885)
@ariya ariya mentioned this issue Feb 23, 2021
Merged
ariya pushed a commit that referenced this issue Feb 25, 2021
@nemanjaglumac @ariya
#14880 Repro: Negative filter can not be converted to custom expressi…
e2d6cab 
…on [ci skip] (#14885)
ariya pushed a commit that referenced this issue Feb 26, 2021
@nemanjaglumac @ariya
#14880 Repro: Negative filter can not be converted to custom expressi…
2000752 
…on [ci skip] (#14885)
@ariya ariya mentioned this issue Feb 26, 2021
Closed
18 tasks
ariya pushed a commit that referenced this issue Mar 1, 2021
@nemanjaglumac @ariya
#14880 Repro: Negative filter can not be converted to custom expressi…
ff45b4a 
…on [ci skip] (#14885)
ariya pushed a commit that referenced this issue Mar 1, 2021
@nemanjaglumac @ariya
#14880 Repro: Negative filter can not be converted to custom expressi…
0129a56 
…on [ci skip] (#14885)
ariya pushed a commit that referenced this issue Mar 2, 2021
@nemanjaglumac @ariya
#14880 Repro: Negative filter can not be converted to custom expressi…
5c11c5e 
…on [ci skip] (#14885)
ariya pushed a commit that referenced this issue Mar 2, 2021
@nemanjaglumac @ariya
#14880 Repro: Negative filter can not be converted to custom expressi…
3011fb2 
…on [ci skip] (#14885)
@rlotun rlotun added this to the 0.39 milestone Mar 5, 2021
@rlotun
Copy link
Contributor

rlotun commented Mar 5, 2021

closed by #15061

This was referenced Feb 5, 2024
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ariya ariya

Labels
Priority:P2 Average run of the mill bug Querying/GUI Query builder catch-all, including simple mode .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
Cypress Testing
Backlog
Milestone
0.39
Development

No branches or pull requests
4 participants
@ariya @rlotun @flamber @nemanjaglumac