-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom expression: new function ISNULL() and ISEMPTY() #14866
Custom expression: new function ISNULL() and ISEMPTY() #14866
Conversation
5a403e7
to
5c7d055
Compare
For historians, might wanna look in #5299 - I think it's great to have specific functions in CE, whereas the regular filter options is fine having "Is empty", which is |
f7075f1
to
1d373a6
Compare
These new functions are to support MBQL's is-null and is-empty.
5c7d055
to
8f47490
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great! 🎉 And the code is just like the other functions, now the backend is in place.
I can even do case(isnull([Field]), "NULL", NOT isnull([Field]), "NOT NULL")
for a CC
These new functions are to support MBQL's is-null and is-empty.
These new functions are to support MBQL's is-null and is-empty.
These new functions are to support MBQL's is-null and is-empty.
These new functions are to support MBQL's is-null and is-empty.
These new functions are to support MBQL's is-null and is-empty.
These new functions are to support MBQL's is-null and is-empty.
These new functions are to support MBQL's is-null and is-empty.
These new functions are to support MBQL's is-null and is-empty. This is to address issue #12225.
Steps to verify
NOT isempty([Reviewer] )
, click Done+
button, another Custom ExpressionNOT isnull([Rating])
, click DoneBefore this PR
It was not possible, since custom expression's
IsNull
andIsEmpty
functions did not exist.After this PR
Additional Note
The simple filter "Is empty" can be also (properly) converted to a custom expression:
The same also works for
Discount
:Note that
is-null
vsis-empty
depends on the field type, see PR #12947 for more details.Related issue: negative filter doesn't get converted yet, see #14880 for more details.