Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't create a filter on joined table #15570

Closed
Thomassso opened this issue Apr 12, 2021 · 2 comments
Closed

Can't create a filter on joined table #15570

Thomassso opened this issue Apr 12, 2021 · 2 comments
Assignees
Labels
.Frontend Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/GUI Query builder catch-all, including simple mode Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects

Comments

@Thomassso
Copy link

Describe the bug
Report goal: create product list and sold product quantity total and product quantity sold with discount.
I couldn't create filter (filter on order.discount column) on joined table.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new Custom question
  2. Coose Products as main table
  3. Left join the Orders table
  4. Try to add filter after the join. Column: order.discount . Filter operator: greater. Filtered value: 0 .
  5. The Add filter button is always inactive, you can't finish the filter creation.

Expected behavior
The Add filter button will be active when everything is set in filter creation window.

Screenshots
Filter_modal_window_with_inactive_button

Information about your Metabase Installation:

{
  "browser-info": {
    "language": "en",
    "platform": "Win32",
    "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.114 Safari/537.36",
    "vendor": "Google Inc."
  },
  "system-info": {
    "file.encoding": "UTF-8",
    "java.runtime.name": "OpenJDK Runtime Environment",
    "java.runtime.version": "1.8.0_262-b10",
    "java.vendor": "AdoptOpenJDK",
    "java.vendor.url": "http://java.oracle.com/",
    "java.version": "1.8.0_262",
    "java.vm.name": "OpenJDK 64-Bit Server VM",
    "java.vm.version": "25.262-b10",
    "os.name": "Linux",
    "os.version": "4.15.0-133-generic",
    "user.language": "en",
    "user.timezone": "GMT"
  },
  "metabase-info": {
    "databases": [
      "postgres",
      "h2"
    ],
    "hosting-env": "unknown",
    "application-database": "h2",
    "application-database-details": {
      "database": {
        "name": "H2",
        "version": "1.4.197 (2018-03-18)"
      },
      "jdbc-driver": {
        "name": "H2 JDBC Driver",
        "version": "1.4.197 (2018-03-18)"
      }
    },
    "run-mode": "prod",
    "version": {
      "tag": "v0.39.0-rc1",
      "date": "2021-04-06",
      "branch": "release-x.39.x",
      "hash": "471eda1"
    },
    "settings": {
      "report-timezone": null
    }
  }
}

Severity
Our employees need to filter data based on various categories. Some of categories are in other tables. We use star schema. Joins are present in most of our reports.

Additional context

@flamber flamber added .Frontend .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/GUI Query builder catch-all, including simple mode Querying/Parameters & Variables Filter widgets, field filters, variables etc. and removed .Needs Triage labels Apr 12, 2021
@flamber
Copy link
Contributor

flamber commented Apr 12, 2021

This seems to apply only for number types - I can filter string and date types, and PK/FK numbers.
And doesn't matter if implicit/explicit - and is in Simple and Notebook

@camsaul camsaul self-assigned this Apr 12, 2021
@nemanjaglumac nemanjaglumac added this to Backlog in Cypress Testing Apr 12, 2021
nemanjaglumac added a commit that referenced this issue Apr 12, 2021
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Apr 12, 2021
@rlotun rlotun added this to Closed Issues and PRs in 39 and 38.x Planning Board Apr 13, 2021
@rlotun rlotun moved this from Closed Issues and PRs to Key Bug fixes (target: 38.4) in 39 and 38.x Planning Board Apr 13, 2021
@camsaul camsaul removed their assignment Apr 13, 2021
@alxnddr alxnddr self-assigned this Apr 13, 2021
@alxnddr
Copy link
Member

alxnddr commented Apr 14, 2021

Fixed by #15605

This was referenced May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Frontend Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/GUI Query builder catch-all, including simple mode Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
39 and 38.x Planning Board
Closed Issues and PRs
Development

No branches or pull requests

5 participants