-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hiding a table makes it impossible to edit existing questions that uses that table #15947
Comments
Should Metabase show a warning or prevent marking a table hidden if it is used in a question? |
Another possibility would be: once a table is hidden still let the query be shown even if you don't allow editing of it. Or, even more minor, at least let the user know why they can't edit the query. I lost a bunch of cycles on this issue so 👍 to getting it fixed. |
@krschacht upvote the original post. We look at the number of those upvotes. |
@nemanjaglumac I don't see an option to upvote anywhere on this issues page. Maybe that's only for people who are part of the Metabase organization? |
@krschacht the left bottom of the first post |
Still able to reproduce this on latest master at d35c779 Please note that converting a question into a model shows "Filter" and "Summarize", and converting it back to the saved question again removes them. |
I think this should remain with the QC team and be triaged by them. There's only a couple of basic conversions of the |
Reproducible in If the fix is to disallow editing queries referencing hidden tables, then it's QC area. I'll change label from BE to FE. |
The issue with hidden joined tables is the same as #37753 and #37751 and will be fixed by making the query readonly in such cases. As for the main issue here, if you hide your source table, you won’t be able to edit the query in the query builder. Is it even a bug? Currently hiding a table makes it invisible in the entire app everywhere except Admin. |
Describe the bug
When questions have been built on tables, which are hidden later, then it's either impossible to edit the question or the question will drop all references to the hidden table.
Possible workaround: Change the table name in Admin > Data Model by prepending
~DEPRECATED
or similar, so the table is added to the end of tables.To Reproduce
It's now not possible to edit the question at all - almost looks like a user without data access
It's possible to edit the question, but making any changes will drop all references to Products table
Expected behavior
This issue might not be straight forward, since it should probably allow existing questions to keep working, but should not include all hidden tables in the API response by default, since that could introduce a performance issue on instances, where perhaps 1k tables have been hidden for technical reasons, because it's not possible to limit via the db privileges.
A possible solution would be to introduce a "Deprecated" along with "Technical" and "Cruft", which would then include those tables in the API.
Information about your Metabase Installation:
Tested 0.37.8 thru 0.39.1
Related to #6445 and #6298
The text was updated successfully, but these errors were encountered: