Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate Google sign-in client IDs #15975

Closed
noahmoss opened this issue May 8, 2021 · 1 comment · Fixed by #19036
Closed

Validate Google sign-in client IDs #15975

noahmoss opened this issue May 8, 2021 · 1 comment · Fixed by #19036
Assignees
@noahmoss
Labels
Administration/Auth Google Auth, LDAP, pw+email login Priority:P2 Average run of the mill bug .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone
0.41.3

Comments

@noahmoss
Copy link
Member

noahmoss commented May 8, 2021 •
edited

Google client IDs have a specific format and are suffixed by .apps.googleusercontent.com. We could do basic validation on client IDs (on the frontend and/or backend) and reject IDs with an incorrect format.
@flamber flamber added Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Type:UX and removed .Needs Triage Type:New Feature labels May 8, 2021
@flamber flamber added the Administration/Auth Google Auth, LDAP, pw+email login label Jun 9, 2021
@flamber flamber mentioned this issue Jun 9, 2021
Merged
@flamber flamber added Priority:P2 Average run of the mill bug Type:Bug Product defects and removed Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Type:UX labels Jun 10, 2021
@flamber
Copy link
Contributor

flamber commented Jun 10, 2021

Changing priority, since I remember this actually causing problems since 0.33.7.3 - #12258 (comment)

@flamber flamber mentioned this issue Nov 18, 2021
Closed
@noahmoss noahmoss mentioned this issue Nov 18, 2021
Merged
@noahmoss noahmoss linked a pull request Nov 18, 2021 that will close this issue
Validate suffix & strip whitespace from Google auth client id #19036
Merged
@flamber flamber added this to the 0.41.3 milestone Nov 24, 2021
@nemanjaglumac nemanjaglumac mentioned this issue Feb 14, 2022
Merged
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Feb 14, 2022
This was referenced Jan 16, 2023
Closed
Merged
@deploysentinel deploysentinel bot mentioned this issue Feb 7, 2023
Merged
This was referenced Feb 21, 2023
Merged
Merged
This was referenced Jan 11, 2024
Merged
Merged
Merged
Merged
This was referenced May 8, 2024
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noahmoss noahmoss

Labels
Administration/Auth Google Auth, LDAP, pw+email login Priority:P2 Average run of the mill bug .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Milestone
0.41.3
Development

Successfully merging a pull request may close this issue.

Validate suffix & strip whitespace from Google auth client id metabase/metabase
3 participants
@flamber @nemanjaglumac @noahmoss