Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to set "Granular" permissions after "Block" is broken #17763

Closed
nemanjaglumac opened this issue Sep 3, 2021 · 4 comments
Closed

Trying to set "Granular" permissions after "Block" is broken #17763

nemanjaglumac opened this issue Sep 3, 2021 · 4 comments
Labels
Administration/Permissions Collection or Data permissions Priority:P2 Average run of the mill bug .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone

Comments

@nemanjaglumac
Copy link
Member

Describe the bug
Trying to set "Granular" permissions after "Block" leads to a table view that is greyed out.

Logs
N/A

To Reproduce
Steps to reproduce the behavior:

  1. Go to /admin/permissions/data/database/1 (Permissions page for "Sample Dataset")
  2. For "All users" group set permission to Block and save
  3. Now change permissions to "Granular"
  4. It will take you to "All users" group tabular permissions page
  5. Note that everything is greyed out and the default values for data permissions are set to "Block"
    image

Refreshing doesn't help.

The workaround is to click on the "Administrators" group in the left sidebar, and then to again click on the "All users" group. This time the page is editable, but it still displays "block".
image

Expected behavior
The page should be editable immediately and it probably makes more sense to default the sections to "no self-service".

Screenshots
Included above.

Information about your Metabase Installation:
local dev, `master, b4a41be, H2, sample dataset

Severity
Since there is a workaround, probably just P3. Would need to wait for an input from the product to figure out what the default permission level for granular tables should be.

@flamber flamber added Administration/Permissions Collection or Data permissions Priority:P2 Average run of the mill bug and removed .Needs Triage labels Sep 4, 2021
@flamber
Copy link
Contributor

flamber commented Sep 4, 2021

Permissions are generally already difficult enough by themselves, so this can add a lot more confusion. Giving P2.

@nemanjaglumac
Copy link
Member Author

@rlotun this was fixed in #17757 2 weeks ago and the repro was unskipped. Did you intentionally assign this to Cam for some additional BE work?

If not, we can close it.

@camsaul
Copy link
Member

camsaul commented Sep 29, 2021

@nemanjaglumac I think is entirely an FE thing, Reza just assigned it to me because it was block-permissions-related.

Closing as fixed by #17757

@camsaul camsaul closed this as completed Sep 29, 2021
@camsaul
Copy link
Member

camsaul commented Sep 29, 2021

Fixed by #17757

This was referenced Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Administration/Permissions Collection or Data permissions Priority:P2 Average run of the mill bug .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Development

No branches or pull requests

3 participants