Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin map only containing null location results causes the frontend to constantly reload or blank page #18061

Closed
flamber opened this issue Sep 26, 2021 · 0 comments · Fixed by #18427
Assignees
Labels
.Frontend Priority:P2 Average run of the mill bug .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects Visualization/Maps
Milestone

Comments

@flamber
Copy link
Contributor

flamber commented Sep 26, 2021

Describe the bug
When results on a Pin map visualization only contains null for latitude/longitude type fields, then it causes the frontend reload loop on question or blank page on dashboard.

P1 contender. Regression since 0.39.0.

Workaround Since Metabase will not show pins for null locations, then add a filter to not include those rows in results.

To Reproduce
It is not possible to reproduce with SQL. The field types has to be Latitude/Longitude in Admin > Data Model

  1. Custom question > Sample Dataset > People
  2. Create two Custom Columns
    1. case([ID] > 1, [Latitude]) as "CClat"
    2. case([ID] > 1, [Longitude]) as "CClong"
  3. Filter by ID less than 3
    image
  4. Change to Map visualization and set Latitude="CClat", Longitude="CClong"
    image
  5. Save question as "Q1"
  6. Change the filter to be less than 2 - the entire frontend goes into a reload loop.
  7. (new tab) Go to a dashboard, add question "Q1" (step 5) and connect a Category filter to People.Source, save dashboard
  8. Set filter widget value to Twitter - the entire frontend reloads once
  9. Share the dashboard as Public/Embedding and input Twitter as the filter - the entire frontend crashes in blank screen.

Information about your Metabase Installation:
Tested 0.38.4 thru 0.40.5 and master 67470a0 - regression since 0.39.0 (0.38.4 just caused error in the browser console)

Additional context
Related to #13736 - historically related to #17940

@flamber flamber added Type:Bug Product defects Priority:P2 Average run of the mill bug Visualization/Maps .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Frontend labels Sep 26, 2021
@nemanjaglumac nemanjaglumac added this to Backlog in Cypress Testing Sep 27, 2021
nemanjaglumac added a commit that referenced this issue Sep 27, 2021
nemanjaglumac added a commit that referenced this issue Sep 27, 2021
…s the frontend (#18073)

Covers all three scenarios listed in the original issue.
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Sep 27, 2021
@ranquild ranquild assigned ranquild and unassigned ranquild Sep 29, 2021
@alxnddr alxnddr self-assigned this Oct 11, 2021
@flamber flamber added this to the 0.41.1 milestone Oct 13, 2021
This was referenced Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Frontend Priority:P2 Average run of the mill bug .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects Visualization/Maps
Projects
Development

Successfully merging a pull request may close this issue.

4 participants