Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboards should work if individual cards are broken #13736

Closed
paulrosenzweig opened this issue Nov 9, 2020 · 3 comments · Fixed by #32910
Closed

Dashboards should work if individual cards are broken #13736

paulrosenzweig opened this issue Nov 9, 2020 · 3 comments · Fixed by #32910
Assignees
@WiNloSt
Labels
.Frontend Priority:P2 Average run of the mill bug Reporting/Dashboards Type:Bug Product defects Visualization/
Projects
Cypress Testing
Milestone
0.47

Comments

@paulrosenzweig
Copy link
Contributor

Dashboards should be robust to errors in specific visualizations. Cam pointed this out in #13721

The card on the left raised an exception while rendering. Both cards appear stuck loading:

image
@flamber flamber mentioned this issue Nov 16, 2020
Closed
@flamber flamber added the Type:Tech Debt or Refactoring label Jan 22, 2021
@flamber
Copy link
Contributor

flamber commented Feb 4, 2021

Very related to #12606

@flamber flamber added Type:Bug Product defects and removed Type:Tech Debt or Refactoring labels Sep 24, 2021
@flamber
Copy link
Contributor

flamber commented Sep 24, 2021 •
edited

Changing to bug, since I have seen this too many times for it to "just" be tech debt. Example #16150 (see Workaround in description). Or #4488, #11142, ...

@flamber flamber mentioned this issue Sep 26, 2021
Closed
This was referenced Nov 7, 2021
Closed
Closed
@yilinjuang yilinjuang mentioned this issue Jan 27, 2022
Closed
@WiNloSt WiNloSt self-assigned this Aug 3, 2023
@WiNloSt
Copy link
Member

WiNloSt commented Aug 3, 2023 •
edited

Doesn't seem to happen on master at 24f1cc9 anymore. This demo works by randomly throw an error on a dashboard card endpoint.

  • image
  • image

@WiNloSt WiNloSt mentioned this issue Aug 3, 2023
Merged
1 task
@WiNloSt WiNloSt added this to the 0.47 milestone Aug 4, 2023
This was referenced Jan 11, 2024
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
This was referenced Feb 5, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WiNloSt WiNloSt

Labels
.Frontend Priority:P2 Average run of the mill bug Reporting/Dashboards Type:Bug Product defects Visualization/
Projects
Cypress Testing
Awaiting triage
Milestone
0.47
Development

Successfully merging a pull request may close this issue.

Add tests to dashboard should work if some cards are broken metabase/metabase
5 participants
@paulrosenzweig @NevRA @flamber @WiNloSt @ranquild