Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot send test emails before creating subscription, when using non-default filter values #18669

Closed
flamber opened this issue Oct 26, 2021 · 0 comments · Fixed by #18965
Closed
Assignees
Labels
.Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Reporting/Dashboards Type:Bug Product defects
Milestone

Comments

@flamber
Copy link
Contributor

flamber commented Oct 26, 2021

Describe the bug
When quickly testing a subscription by modifying the filters (Enterprise), then it's not possible to send test email.
Regression since 1.41.0 - worked on 1.40.5

Workaround: Save the subscription with modified filter value, then go to the subscription again and click "Send email now".

To Reproduce

  1. Add question to a dashboard with a filter - using Count of Products, filter connected to Category with default value Doohickey
    image
  2. Subscription > Email > change filter value to something different than default, ex Gadget
    image
  3. Click "Send email now" - it instantly changes to "Sending failed" without any requests being sent, but the browser errors with:
TypeError: Converting circular structure to JSON
    --> starting at object with constructor 'f'
    |     property 'databases' -> object with constructor 'Object'
    |     property '1' -> object with constructor 'l'
    --- property 'metadata' closes the circle
    at JSON.stringify (<anonymous>)
    at api.js:126
    at l (runtime.js:63)
    at Generator._invoke (runtime.js:293)
    at Generator.next (runtime.js:118)
    at p (app-main.bundle.js?bd9515e770dfa46d6cc9:2)
    at a (app-main.bundle.js?bd9515e770dfa46d6cc9:2)
    at app-main.bundle.js?bd9515e770dfa46d6cc9:2
    at new Promise (<anonymous>)
    at Object.<anonymous> (app-main.bundle.js?bd9515e770dfa46d6cc9:2)
(anonymous) @ ActionButton.jsx:103

Information about your Metabase Installation:
Tested 1.40.5 thru 1.41.1 - regression since 1.41.0

@flamber flamber added Type:Bug Product defects Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Reporting/Dashboards Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Frontend .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. labels Oct 26, 2021
@flamber flamber added this to the 0.41.3 milestone Nov 15, 2021
This was referenced Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Reporting/Dashboards Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants