Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register keywords defined by mr/def for LSP #37616

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

camsaul
Copy link
Member

@camsaul camsaul commented Jan 11, 2024

In Emacs M-x lsp-find-declaration which is the totally convenient keybinding <super>-l g g for me jumps to the malli schema definition after adding this hook

@metabase-bot metabase-bot bot added the .Team/QueryProcessor :hammer_and_wrench: label Jan 11, 2024
Copy link

replay-io bot commented Jan 11, 2024

StatusIn Progress ↗︎ 51 / 52
Commit3d55873
Results
⚠️ 2 Flaky
  • should allow non-user to unsubscribe from subscription
      Timed out retrying after 4000ms: Expected to find content: 'You've unsubscribed non-user@example.com from the "Orders in a dashboard" alert.' but never did.
  • with CountIf
2212 Passed

@camsaul camsaul added the no-backport Do not backport this PR to any branch label Jan 12, 2024
@camsaul camsaul requested a review from a team January 18, 2024 21:37
@camsaul camsaul enabled auto-merge (squash) January 18, 2024 21:37
Copy link
Contributor

@metamben metamben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🎉

@camsaul camsaul merged commit 784759b into master Jan 19, 2024
112 of 113 checks passed
@camsaul camsaul deleted the lsp-Malli-registry-keyword-registration branch January 19, 2024 14:09
Copy link

@camsaul Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/QueryProcessor :hammer_and_wrench:
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants