Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embedding/Public sharing of questions does not show download button in the footer #21993

Closed
flamber opened this issue Apr 25, 2022 · 3 comments · Fixed by #22033
Closed

Embedding/Public sharing of questions does not show download button in the footer #21993

flamber opened this issue Apr 25, 2022 · 3 comments · Fixed by #22033
Assignees
@alxnddr
Labels
Embedding/Public Simple public iframe embeds Embedding/Static Static embedding, previously known as signed embedding .Frontend Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Reporting/Export Type:Bug Product defects
Milestone
0.43

Comments

@flamber
Copy link
Contributor

flamber commented Apr 25, 2022

Describe the bug
Embedding/Public sharing of questions does not show download button in the footer.
Regression since 0.43.0-rc1

To Reproduce

  1. Native > Sample > select 0 - save question
  2. Click Sharing (:arrow_upper_right:)
  3. Go to Public Sharing or Embedding
    image
    image

Expected behavior
0.42.4
image
image

Information about your Metabase Installation:
Tested 0.42.4 thru 0.43.0-rc1 and master 485b83e
@flamber flamber added Type:Bug Product defects Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness .Frontend Embedding/Public Simple public iframe embeds Embedding/Static Static embedding, previously known as signed embedding .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. labels Apr 25, 2022
@flamber flamber added this to the 0.43 milestone Apr 25, 2022
@alxnddr alxnddr self-assigned this Apr 25, 2022
@alxnddr
Copy link
Member

alxnddr commented Apr 25, 2022

@flamber this was intentional https://metaboat.slack.com/archives/C0312QQCHLP/p1645816847443499?thread_ts=1645809456.524589&cid=C0312QQCHLP

@flamber
Copy link
Contributor Author

flamber commented Apr 25, 2022

Someone needs to comment with details here. This has to be highest note in our release notes. I know a lot who won't upgrade.

@alxnddr
Copy link
Member

alxnddr commented Apr 25, 2022

While working on the new download permission, we intentionally removed the ability to download data from publicly shared questions for security concerns. Please let us know if it was important for you.

@alxnddr alxnddr closed this as completed Apr 25, 2022
@flamber flamber removed this from the 0.43 milestone Apr 25, 2022
@luizarakaki luizarakaki reopened this Apr 25, 2022
@flamber flamber added this to the 0.43 milestone Apr 25, 2022
@alxnddr alxnddr mentioned this issue Apr 25, 2022
Merged
This was referenced Dec 1, 2022
Closed
Merged
@deploysentinel deploysentinel bot mentioned this issue Jan 4, 2023
Closed
1 task
This was referenced Feb 16, 2023
Merged
Merged
This was referenced Mar 15, 2023
Merged
Merged
Merged
@deploysentinel deploysentinel bot mentioned this issue Mar 27, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue Apr 11, 2023
Draft
This was referenced May 8, 2024
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alxnddr alxnddr

Labels
Embedding/Public Simple public iframe embeds Embedding/Static Static embedding, previously known as signed embedding .Frontend Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Reporting/Export Type:Bug Product defects
Projects
None yet
Milestone
0.43
Development

Successfully merging a pull request may close this issue.

return download results button to publicly shared questions metabase/metabase
3 participants
@flamber @alxnddr @luizarakaki