-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MLv2] Use FilterPicker
for QB filter pills
#34851
Conversation
Codenotify: Notifying subscribers in CODENOTIFY files for diff ce3aff7...4cd7d1a.
|
Current Cypress Test Results Summary✅ 133 Passing - ❌ 6 Failing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 11/15/2023 05:41:44pm UTC) Run DetailsRunning Workflow E2E Tests on Github Actions Commit: 238bf5d Started: 11/15/2023 04:47:24pm UTC ❌ Failures📄 e2e/test/scenarios/visualizations-tabular/pivot_tables.cy.spec.js • 3 FailuresTest Case Results
📄 e2e/test/scenarios/question/notebook.cy.spec.js • 2 FailuresTest Case Results
📄 e2e/test/scenarios/dashboard/x-rays.cy.spec.js • 1 FailureTest Case Results
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
scenarios > visualizations > pivot tables should allow sorting fields
Retry 1 • Initial Attempt |
0% (0)0 / 324 runsfailed over last 7 days |
53.40% (173)173 / 324 runsflaked over last 7 days |
Current Cypress Test Results Summary
✅ 1996 Passing - ❌ 29 Failing -
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 11/15/2023 05:41:44pm UTC)
Run Details
Running Workflow E2E Tests on Github Actions
Commit: 238bf5d
Started: 11/15/2023 04:44:43pm UTC
❌ Failures
📄 e2e/test/scenarios/filters/filter-types.cy.spec.js • 11 Failures
Top 1 Common Error Messages
|
10 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
scenarios > filters > filter types number filters not equal to
Retry 2 • Retry 1 • Initial Attempt Error: `cy.within()` can only be called on a single element. Your subject contained 2 e...
|
100% (26)26 / 26 runsfailed over last 7 days |
0% (0)0 / 26 runsflaked over last 7 days |
scenarios > filters > filter types date filters relative filters yesterday
Retry 2 • Retry 1 • Initial Attempt Error: Timed out retrying after 4000ms: Expected container to be an Element, a Document...
|
100% (26)26 / 26 runsfailed over last 7 days |
0% (0)0 / 26 runsflaked over last 7 days |
scenarios > filters > filter types date filters relative filters previous 7 days
Retry 2 • Retry 1 • Initial Attempt Error: Timed out retrying after 4000ms: Expected container to be an Element, a Document...
|
100% (26)26 / 26 runsfailed over last 7 days |
0% (0)0 / 26 runsflaked over last 7 days |
scenarios > filters > filter types date filters relative filters previous 3 weeks starting a quarter ago
Retry 2 • Retry 1 • Initial Attempt Error: Timed out retrying after 4000ms: Expected container to be an Element, a Document...
|
100% (26)26 / 26 runsfailed over last 7 days |
0% (0)0 / 26 runsflaked over last 7 days |
scenarios > filters > filter types date filters relative filters previous month
Retry 2 • Retry 1 • Initial Attempt Error: Timed out retrying after 4000ms: Expected container to be an Element, a Document...
|
100% (26)26 / 26 runsfailed over last 7 days |
0% (0)0 / 26 runsflaked over last 7 days |
scenarios > filters > filter types date filters relative filters previous 3 months
Retry 2 • Retry 1 • Initial Attempt Error: Timed out retrying after 4000ms: Expected container to be an Element, a Document...
|
100% (26)26 / 26 runsfailed over last 7 days |
0% (0)0 / 26 runsflaked over last 7 days |
scenarios > filters > filter types date filters relative filters previous two quarters
Retry 2 • Retry 1 • Initial Attempt Error: Timed out retrying after 4000ms: Expected container to be an Element, a Document...
|
100% (26)26 / 26 runsfailed over last 7 days |
0% (0)0 / 26 runsflaked over last 7 days |
scenarios > filters > filter types date filters relative filters next 6 hours
Retry 2 • Retry 1 • Initial Attempt Error: Timed out retrying after 4000ms: Expected container to be an Element, a Document...
|
100% (26)26 / 26 runsfailed over last 7 days |
0% (0)0 / 26 runsflaked over last 7 days |
scenarios > filters > filter types date filters relative filters tomorrow
Retry 2 • Retry 1 • Initial Attempt Error: Timed out retrying after 4000ms: Expected container to be an Element, a Document...
|
100% (26)26 / 26 runsfailed over last 7 days |
0% (0)0 / 26 runsflaked over last 7 days |
scenarios > filters > filter types date filters relative filters next 7 days starting next month
Retry 2 • Retry 1 • Initial Attempt Error: Timed out retrying after 4000ms: Expected container to be an Element, a Document...
|
100% (26)26 / 26 runsfailed over last 7 days |
0% (0)0 / 26 runsflaked over last 7 days |
scenarios > filters > filter types date filters relative filters next year
Retry 2 • Retry 1 • Initial Attempt Error: Timed out retrying after 4000ms: Expected container to be an Element, a Document...
|
100% (26)26 / 26 runsfailed over last 7 days |
0% (0)0 / 26 runsflaked over last 7 days |
📄 e2e/test/scenarios/custom-column/cc-data-type.cy.spec.js • 3 Failures
Top 1 Common Error Messages
|
3 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
scenarios > question > custom column > data type should relay the type of a date field
Retry 2 • Retry 1 • Initial Attempt Error: Timed out retrying after 4000ms: Expected container to be an Element, a Document...
|
6.39% (29)29 / 454 runsfailed over last 7 days |
0.22% (1)1 / 454 runflaked over last 7 days |
scenarios > question > custom column > data type should handle CASE (#13122)
Retry 2 • Retry 1 • Initial Attempt Error: Timed out retrying after 4000ms: Expected container to be an Element, a Document...
|
6.39% (29)29 / 454 runsfailed over last 7 days |
0% (0)0 / 454 runsflaked over last 7 days |
scenarios > question > custom column > data type should handle COALESCE
(truncated)... |
c89c2c3
to
621430a
Compare
621430a
to
b4c8d94
Compare
cb92bb3
to
44555ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just improving a11y along the way as I was updating the e2e tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
relative-datetime.cy.spec.js
test-suite has a set of helpers that are used for both old date picker and new date picker (because the test suite uses the new FilterPicker
in the filter pills and the old FilterPopover
in filter drills). I've added the same a11y labels to the old component, so we can use nice element queries like findLabelText
and avoid conditional logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once #34962, #35363, and #35369 are completed, we should switch the test suite to use e2e-relative-date-picker-helpers
FilterPicker
for QB filter pillsFilterPicker
for QB filter pills
The
QuestionFilters.jsx
components clean up is cherry-picked here from #34852