Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] Remove ability for users to edit SSO created user info #23298

Closed
2 tasks done
WiNloSt opened this issue Jun 13, 2022 · 0 comments · Fixed by #23332 or #23476
Closed
2 tasks done

[Epic] Remove ability for users to edit SSO created user info #23298

WiNloSt opened this issue Jun 13, 2022 · 0 comments · Fixed by #23332 or #23476
Assignees
Labels
.Epic Feature Implementation or Project .Reproduced Issues reproduced in test (usually Cypress)
Milestone

Comments

@WiNloSt
Copy link
Member

WiNloSt commented Jun 13, 2022

It doesn't make much sense for users who logged in with SSO to be able to change their account information e.g. names, email since their information will already be synced each time users log in (correct me if I'm wrong, but basically SSO data will be syncing to Metabase). Being able to change their own account info makes the data out of sync with SSO providers.

Links

Implementation Plan

This is most likely a 99% FE-only project. But depending on how we currently determine SSO users this could involve BE.

Milestone 1 - Implement FE

How to Test This Feature Out

SSO user

  1. Setup SSO
  2. Login with SSO
  3. Go to the account page, should not see first name, last name, and email field anymore.

email + password user

  1. Login with email + password
  2. Go to the account page, should still see first name, last name, and email field and edit them.
@WiNloSt WiNloSt added the .Epic Feature Implementation or Project label Jun 13, 2022
@WiNloSt WiNloSt self-assigned this Jun 13, 2022
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Jun 21, 2022
@WiNloSt WiNloSt reopened this Jun 22, 2022
@ranquild ranquild added this to the 0.44 milestone Jul 6, 2022
This was referenced Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Epic Feature Implementation or Project .Reproduced Issues reproduced in test (usually Cypress)
Projects
None yet
3 participants