Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saved Questions data selector lists all questions for collections with the same name #24660

Closed
flamber opened this issue Aug 8, 2022 · 0 comments · Fixed by #29698
Closed
Assignees
Labels
.Backend .Frontend Organization/Collections Priority:P2 Average run of the mill bug Querying/GUI Query builder catch-all, including simple mode .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone

Comments

@flamber
Copy link
Contributor

flamber commented Aug 8, 2022

Describe the bug
When sub-collections has the same name in several parent-collections, then the Saved Question picker will show all questions from all the sub-collections, which can be confusing.
Seems like both BE and FE needs some adjustment.

To Reproduce

  1. Create two parent collections, "Parent1" and "Parent2"
  2. Then create a sub-collection within both parents called "same-child-name"
  3. Create two questions, save "Q1" to "Parent1/same-child-name" and save "Q2" to "Parent2/same-child-name"
  4. New question > Saved Questions > "Parent1" > "same-child-name" - it will show both questions, since the request is for /api/database/-1337/schema/same-child-name without any ID or parent to make the distinction.
    image

Expected behavior
Only show the questions related to the specific collection selected.

Information about your Metabase Installation:
Tested 0.41.7 thru 0.44.0

@flamber flamber added Type:Bug Product defects Priority:P2 Average run of the mill bug Organization/Collections Querying/GUI Query builder catch-all, including simple mode labels Aug 8, 2022
nemanjaglumac added a commit that referenced this issue Oct 13, 2022
nemanjaglumac added a commit that referenced this issue Oct 14, 2022
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Oct 14, 2022
github-actions bot pushed a commit that referenced this issue Oct 14, 2022
metabase-bot bot added a commit that referenced this issue Oct 14, 2022
…ollections with the same name (#25919) (#25929)

Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
@deniskaber deniskaber self-assigned this Mar 30, 2023
This was referenced Feb 5, 2024
@darksciencebase darksciencebase added this to the 0.47 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Backend .Frontend Organization/Collections Priority:P2 Average run of the mill bug Querying/GUI Query builder catch-all, including simple mode .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants