Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip periods are not displayed nicely on SQL questions #25007

Closed
Tony-metabase opened this issue Aug 25, 2022 · 0 comments · Fixed by #25140
Closed

Tooltip periods are not displayed nicely on SQL questions #25007

Tony-metabase opened this issue Aug 25, 2022 · 0 comments · Fixed by #25140
Assignees
@ranquild
Labels
.Frontend Priority:P2 Average run of the mill bug Querying/Native The SQL/native query editor .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects Visualization/Charts Line, area, bar, combo, and scatter charts.
Milestone
0.44.3

Comments

@Tony-metabase
Copy link
Contributor

Tony-metabase commented Aug 25, 2022 •
edited

Describe the bug
When you group by week/month on Editor the result is a range:

image

If you take the same question and turn it into SQL. The tooltip doesn't pick up the range granularity :

image

To Reproduce
Steps to reproduce the behavior:

  1. Go to New -> Question -> Sample Database -> Orders -> Summarise Count -> Group by Created At (Choose Week)
  2. Notice the preview dates are in "April 24, 2016 – April 30, 2016" format
  3. Go to View this SQL Icon -> Convert Question to SQL -> Re-Run
  4. Notice the dates are in "April 24, 2016 " format
  5. Tooltip Granularity is lost

Expected behavior
Same behavior is expected from both Question and Native SQL. This issue got introduced in 44 since previously to this version they where experiencing similar outcome. In version 43 the output was as following:

image
@flamber flamber changed the title Date Range Granularity not showing on Native SQL Tooltip periods are not displayed nicely on SQL questions Aug 25, 2022
@flamber flamber added Priority:P2 Average run of the mill bug Querying/Native The SQL/native query editor .Frontend Visualization/Charts Line, area, bar, combo, and scatter charts. .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. and removed .Needs Triage labels Aug 25, 2022
@ranquild ranquild self-assigned this Aug 29, 2022
@ranquild ranquild mentioned this issue Aug 31, 2022
Merged
@ranquild ranquild added the .Reproduced Issues reproduced in test (usually Cypress) label Aug 31, 2022
@flamber flamber added this to the 0.44.3 milestone Sep 1, 2022
@deploysentinel deploysentinel bot mentioned this issue Jan 6, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue Jan 13, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue Jan 20, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue Mar 16, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue Jul 4, 2023
Merged
1 task
This was referenced Jan 11, 2024
Merged
Merged
Merged
Merged
Merged
Draft
Merged
Merged
Merged
Merged
Merged
This was referenced Feb 5, 2024
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ranquild ranquild

Labels
.Frontend Priority:P2 Average run of the mill bug Querying/Native The SQL/native query editor .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects Visualization/Charts Line, area, bar, combo, and scatter charts.
Projects
None yet
Milestone
0.44.3
Development

Successfully merging a pull request may close this issue.

Fix how weeks are displayed in tooltips for native questions metabase/metabase
3 participants
@flamber @ranquild @Tony-metabase