Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comma separated filter value would not hand over from dashboard to question #25374

Closed
mskako opened this issue Sep 13, 2022 · 4 comments · Fixed by #27436
Closed

Comma separated filter value would not hand over from dashboard to question #25374

mskako opened this issue Sep 13, 2022 · 4 comments · Fixed by #27436
Assignees
Labels
.Correctness .Frontend Priority:P2 Average run of the mill bug Querying/Native The SQL/native query editor Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone

Comments

@mskako
Copy link

mskako commented Sep 13, 2022

Describe the bug
Comma separated filter value would not hand over from dashboard to question

Logs

To Reproduce
Steps to reproduce the behavior:

  1. Create Dashboard with default value of comma separated multiple values
  2. Open dashboard
  3. Click question title which uses 1's default value
  4. Only top 1 value will be taken over. Rest of them will be omitted.

Expected behavior
All of separated values will be taken over.

Screenshots
MicrosoftTeams-image (1)

Information about your Metabase Installation:
Docker image metabase/metabase:v0.44.2

You can get this information by going to Admin -> Troubleshooting.

  • Your browser and the version: Chrome 105.0.5195.102, Firefox 104.0.2
  • Your operating system: Windows 10 Enterprise 21H2(Client)
  • Your databases: MySQL
  • Metabase version: v.0.44.2
  • Metabase hosting environment: Docker
  • Metabase internal database: MySQL

Severity
Customers' use case always starts with this dashboard and they move to each questions and export CSVs. Unless values taken over properly, their business flow will be stopped.

Additional context
On v.0.41.5, it doesn't happen.

@mskako mskako added .Needs Triage Type:Bug Product defects labels Sep 13, 2022
@flamber flamber added Priority:P2 Average run of the mill bug .Correctness Querying/Parameters & Variables Filter widgets, field filters, variables etc. Querying/Native The SQL/native query editor .Frontend .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. and removed .Needs Triage labels Oct 9, 2022
@flamber
Copy link
Contributor

flamber commented Oct 9, 2022

Regression since 0.44.0

A possible workaround is to change the variable to Text and turn it into an array #4728, or use a Field Filter. But both options might be difficult to implement depending on dashboard count, database type or how the query is created.

Reproduce:

  1. Native > Sample > select count(*) from orders where id in ({{number}}) - change variable to Number - save question
  2. Add question to dashboard, add filter Number equal and connect to card, save dashboard
  3. Input 1,2,3 in filter, which gives expected results
    image
  4. Click question title goes to the question, and the URL quickly flashes from =1,2,3 to =1 and give unexpected results
    image

@wincelau
Copy link

I also noticed this bug on version 0.43.4

@nemanjaglumac
Copy link
Member

Refreshing the dashboard also removes all values except the first one.
Which is also the equivalent of visiting the dashboard while trying to pass parameters through URL:
/dashboard/:id?equal_to=1%2C2%2C3

nemanjaglumac added a commit that referenced this issue Dec 22, 2022
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Dec 22, 2022
nemanjaglumac added a commit that referenced this issue Dec 23, 2022
* Repro #25374: Comma-separated dashboard filter values not passed down to the question (#27381)

* Repro #25927: Column filters not working on questions with custom columns (#27388)

* Repro #27123: Exclude filter always ends up showing "Days of the week" (#27389)

* Repro #27380: Doing "Zoom in" from dashboard drops fields from joined tables (#27390)
@gusaiani gusaiani self-assigned this Dec 27, 2022
@flamber flamber added this to the 0.45.2 milestone Jan 9, 2023
@mskako
Copy link
Author

mskako commented Jan 18, 2023

I just have checked on v.0.45.2, it works properly. Thanks!!

This was referenced Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Correctness .Frontend Priority:P2 Average run of the mill bug Querying/Native The SQL/native query editor Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants