Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude filter always ends up showing "Days of the week" #27123

Closed
nemanjaglumac opened this issue Dec 9, 2022 · 0 comments · Fixed by #27825
Closed

Exclude filter always ends up showing "Days of the week" #27123

nemanjaglumac opened this issue Dec 9, 2022 · 0 comments · Fixed by #27825
Assignees
@ranquild
Labels
.Frontend Priority:P2 Average run of the mill bug Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone
0.46

Comments

@nemanjaglumac
Copy link
Member

nemanjaglumac commented Dec 9, 2022 •
edited

Describe the bug
No matter which option you choose, exclude filter always ends up showing "days of week".

To Reproduce
Steps to reproduce the behavior:

  1. New question > Sample Database > Orders
  2. Filter on "Created At" and choose "Exclude" filter
  3. Choose "Months of the year..." (or "Quarters of the year..." or "Hours of the day...") and "Add filter"
  4. The filter popover shows "Days of the week..." regardless of your choice

image

Expected behavior
Filter popover should respect users' selection.

Information about your Metabase Installation:
local dev, master, 8ca7770, H2, Sample Database

Severity
It renders all other options useless. I'd say at least P2, since I'm not sure if there is a workaround (maybe with custom expressions?)
@nemanjaglumac nemanjaglumac changed the title Exclude filter always ends up showing "days of week" Exclude filter always ends up showing "Days of the week" Dec 9, 2022
@flamber flamber added Priority:P2 Average run of the mill bug Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Frontend .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. and removed .Needs Triage labels Dec 10, 2022
nemanjaglumac added a commit that referenced this issue Dec 22, 2022
@nemanjaglumac
Add repro for #27123 [ci skip]
e86447f
@nemanjaglumac nemanjaglumac mentioned this issue Dec 22, 2022
Merged
nemanjaglumac added a commit that referenced this issue Dec 23, 2022
@nemanjaglumac
Repro #27123: Exclude filter always ends up showing "Days of the week" (
3077bce 
#27389)
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Dec 23, 2022
nemanjaglumac added a commit that referenced this issue Dec 23, 2022
@nemanjaglumac
Repro #27123: Exclude filter always ends up showing "Days of the week" (
993c139 
#27389)
nemanjaglumac added a commit that referenced this issue Dec 23, 2022
@nemanjaglumac
🍒 Backport repros created on 2022-12-22 (#27397)
124dff9 
* Repro #25374: Comma-separated dashboard filter values not passed down to the question (#27381)

* Repro #25927: Column filters not working on questions with custom columns (#27388)

* Repro #27123: Exclude filter always ends up showing "Days of the week" (#27389)

* Repro #27380: Doing "Zoom in" from dashboard drops fields from joined tables (#27390)
@Tony-metabase Tony-metabase mentioned this issue Jan 9, 2023
Open
@ranquild ranquild self-assigned this Jan 23, 2023
@ranquild ranquild mentioned this issue Jan 23, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue Feb 3, 2023
Merged
@nemanjaglumac nemanjaglumac added this to the 0.46 milestone Mar 2, 2023
This was referenced Jan 11, 2024
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
This was referenced Feb 5, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ranquild ranquild

Labels
.Frontend Priority:P2 Average run of the mill bug Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Milestone
0.46
Development

Successfully merging a pull request may close this issue.

Fix exclude filter not working with other date time units metabase/metabase
5 participants
@flamber @ranquild @alxnddr @nemanjaglumac @darksciencebase