Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doing "Zoom in" from dashboard drops fields from joined tables #27380

Closed
flamber opened this issue Dec 22, 2022 · 1 comment · Fixed by #28022 or #31117
Closed

Doing "Zoom in" from dashboard drops fields from joined tables #27380

flamber opened this issue Dec 22, 2022 · 1 comment · Fixed by #28022 or #31117
Assignees
@WiNloSt
Labels
.Frontend Priority:P2 Average run of the mill bug Querying/GUI Query builder catch-all, including simple mode .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Reporting/Dashboards .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone
0.46.5

Comments

@flamber
Copy link
Contributor

flamber commented Dec 22, 2022

Describe the bug
Doing "Zoom in" drill from dashboard drops fields from joined tables used in the group-by. This does not happen when using drag-to-zoom.

Possible workaround is to click the question title on the dashboard, or use drag-to-zoom on the dashboard.

To Reproduce

  1. Question > Sample > Orders
  2. Summarize Count grouped by Products.CreatedAt:Month (doesn't matter if Products is implicit or explicit joined).
  3. Save question and add to dashboard
  4. Click one of the line points and "Zoom in" - shows invalid chart (not a very helpful error) and looking in Notebook will show that it has dropped the group-by field.
Screencast-2022-12-22_13.45.38.mp4

Information about your Metabase Installation:
Tested 0.45.1

Additional context
Feels related to #23293
@flamber flamber added Type:Bug Product defects Priority:P2 Average run of the mill bug Reporting/Dashboards .Frontend Querying/GUI Query builder catch-all, including simple mode labels Dec 22, 2022
nemanjaglumac added a commit that referenced this issue Dec 22, 2022
@nemanjaglumac
Add repro for #27380 [ci skip]
d0a3b2a
@nemanjaglumac nemanjaglumac mentioned this issue Dec 22, 2022
Merged
nemanjaglumac added a commit that referenced this issue Dec 23, 2022
@nemanjaglumac
Repro #27380: Doing "Zoom in" from dashboard drops fields from joined…
5863b1f 
… tables (#27390)
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Dec 23, 2022
nemanjaglumac added a commit that referenced this issue Dec 23, 2022
@nemanjaglumac
Repro #27380: Doing "Zoom in" from dashboard drops fields from joined…
24b790b 
… tables (#27390)
nemanjaglumac added a commit that referenced this issue Dec 23, 2022
@nemanjaglumac
🍒 Backport repros created on 2022-12-22 (#27397)
124dff9 
* Repro #25374: Comma-separated dashboard filter values not passed down to the question (#27381)

* Repro #25927: Column filters not working on questions with custom columns (#27388)

* Repro #27123: Exclude filter always ends up showing "Days of the week" (#27389)

* Repro #27380: Doing "Zoom in" from dashboard drops fields from joined tables (#27390)
@ranquild ranquild self-assigned this Feb 2, 2023
@ranquild ranquild mentioned this issue Feb 2, 2023
Merged
@ranquild ranquild added this to the 0.45.3 milestone Feb 6, 2023
This was referenced Feb 7, 2023
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Feb 15, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Mar 20, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@replay-io replay-io bot mentioned this issue Mar 28, 2024
Merged
1 task
This was referenced Apr 4, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
This was referenced Apr 12, 2024
Merged
Merged
Merged
Merged
Merged
This was referenced Apr 23, 2024
Merged
Merged
Merged
Merged
Merged
This was referenced May 2, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WiNloSt WiNloSt

Labels
.Frontend Priority:P2 Average run of the mill bug Querying/GUI Query builder catch-all, including simple mode .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Reporting/Dashboards .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Milestone
0.46.5
6 participants
@flamber @WiNloSt @ranquild @alxnddr @nemanjaglumac @darksciencebase