Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When LDAP is enabled but password login is disabled, login doesn't work #25661

Closed
noahmoss opened this issue Sep 27, 2022 · 0 comments · Fixed by #25674
Closed

When LDAP is enabled but password login is disabled, login doesn't work #25661

noahmoss opened this issue Sep 27, 2022 · 0 comments · Fixed by #25674
Assignees
Labels
.Frontend Priority:P2 Average run of the mill bug .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone

Comments

@noahmoss
Copy link
Member

Describe the bug
If you set up and enable LDAP, but toggle off the "Enable Password Authentication" setting, the login screen will say "Sign in to Metabase" not present any authentication options.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Admin -> Settings -> Authentication
  2. Set up and enable LDAP. The easiest way I've found for this is to use these credentials for a free online testing server, but you can also run one locally.
  3. Scroll down to "Enable Password Authentication" and disable it
  4. Log out
  5. The login screen will not present any authentication options

Expected behavior
I guess we should still show the login form but only attempt to hit the LDAP server when you submit it, not attempt normal email/password login as well

Screenshots
Screen Shot 2022-09-27 at 3 28 16 PM

Information about your Metabase Installation:
Current master

Severity
Pretty serious, it's an easy way to get locked out of an instance. Can be recovered from by setting MB_ENABLE_PASSWORD_LOGIN=true.

@noahmoss noahmoss added Type:Bug Product defects .Needs Triage labels Sep 27, 2022
@ranquild ranquild self-assigned this Sep 28, 2022
@ranquild ranquild added this to the 0.44.4 milestone Sep 28, 2022
@ranquild ranquild added .Frontend .Reproduced Issues reproduced in test (usually Cypress) labels Sep 28, 2022
@flamber flamber added Priority:P2 Average run of the mill bug and removed .Needs Triage labels Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Frontend Priority:P2 Average run of the mill bug .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants