Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal filtering doesn't work on joined table when Question has a filter after aggregation #25990

Closed
Tony-metabase opened this issue Oct 18, 2022 · 1 comment · Fixed by #26156
Closed

Modal filtering doesn't work on joined table when Question has a filter after aggregation #25990

Tony-metabase opened this issue Oct 18, 2022 · 1 comment · Fixed by #26156
Assignees
@ranquild
Labels
.Frontend Priority:P2 Average run of the mill bug Querying/GUI Query builder catch-all, including simple mode Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone
0.45

Comments

@Tony-metabase
Copy link
Contributor

Tony-metabase commented Oct 18, 2022 •
edited

Describe the bug
I am not able to select any option from the Modal filtering off a joined table within a Question that has a filter after aggregation.

To Reproduce
Steps to reproduce the behavior:

  1. Go to New Question -> Sample Database -> Orders -> Join with People -> Summarise Count by Created At: Month -> Filter Count Greater than 1

image

  1. Visualize Result -> Click on Modal Filtering -> Try to Filter on the Joined Table -> Name is Tony -> Apply Filters

image

  1. No filtering is applied

Expected behavior
If I have the option to Filter then I should be able to Filter

Information about your Metabase Installation:

Metabase 1.44.4

Workaround

Don't use the Modal Filtering but go back to the GUI Editor and setup required Filtering from there

image
@flamber flamber added Priority:P2 Average run of the mill bug Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Frontend Querying/GUI Query builder catch-all, including simple mode .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. and removed .Needs Triage labels Oct 18, 2022
@flamber
Copy link
Contributor

flamber commented Oct 18, 2022

Kinda a regression, but 44.3 would cause the problems that #25417 fixed.

@ranquild ranquild self-assigned this Oct 26, 2022
@ranquild ranquild mentioned this issue Oct 28, 2022
Merged
@ranquild ranquild added the .Reproduced Issues reproduced in test (usually Cypress) label Oct 31, 2022
@ranquild ranquild added this to the 0.45 milestone Nov 1, 2022
@deploysentinel deploysentinel bot mentioned this issue Dec 14, 2022
Merged
This was referenced Feb 3, 2023
Merged
Merged
@deploysentinel deploysentinel bot mentioned this issue Aug 18, 2023
Merged
This was referenced Jan 11, 2024
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Closed
This was referenced Feb 5, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ranquild ranquild

Labels
.Frontend Priority:P2 Average run of the mill bug Querying/GUI Query builder catch-all, including simple mode Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Milestone
0.45
Development

Successfully merging a pull request may close this issue.

Fix filtering by join dimensions metabase/metabase
3 participants
@flamber @ranquild @Tony-metabase