Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pivot Table requires results to be loaded before Summarize fields can be changed #26467

Closed
flamber opened this issue Nov 13, 2022 · 2 comments · May be fixed by #26784
Closed

Pivot Table requires results to be loaded before Summarize fields can be changed #26467

flamber opened this issue Nov 13, 2022 · 2 comments · May be fixed by #26784
Assignees
Labels
.Frontend Priority:P2 Average run of the mill bug Querying/Notebook Items specific to the Custom/Notebook query builder Type:Bug Product defects Visualization/Tables Raw, summarized, and pivoted tables
Milestone

Comments

@flamber
Copy link
Contributor

flamber commented Nov 13, 2022

Describe the bug
The Summarize group-by fields are nonfunctional on Pivot Table until results are loaded making the UI feel broken or slow.
Since Pivot Table visualization is a lot slower than any other visualization, then it is easy to encounter this problem. #21688

Workaround: Wait for results to be loaded, then changes to the summarize group-by works.

To Reproduce

  1. Create an intentionally slow query - save question as "Slow query"
-- postgres
select 1 as ID, 'cat' as VAL, 'cat2' as VAL2, pg_sleep(10)
-- mysql
select 1 as ID, 'cat' as VAL, 'cat2' as VAL2, sleep(10)
  1. Question > Saved Questions > "Slow query" - summarize Count grouped by VAL
    image
  2. Change visualization to Pivot Table - wait for it to finish load results
  3. Save question and do a browser refresh
  4. While results are being loaded, try changing the summarize group-by fields - nothing happens
Uncaught (in promise) TypeError: Cannot read properties of null (reading '0')
    at e (icepick.min.js:1:2152)
    at core.js:276:22
    at u (runtime.js:63:40)
    at Generator._invoke (runtime.js:293:22)
    at Generator.next (runtime.js:118:21)
    at Vt (native.js:149:63)
    at a (native.js:149:63)
    at native.js:149:63
    at new Promise (<anonymous>)
    at native.js:149:63
Screencast-2022-11-13_12.37.01.mp4

Expected behavior
Should be possible the change summarized fields before results are loaded, since metadata is already available.

Information about your Metabase Installation:
Tested 0.44.6

@flamber flamber added Type:Bug Product defects Priority:P2 Average run of the mill bug .Frontend Querying/GUI Query builder catch-all, including simple mode Visualization/Tables Raw, summarized, and pivoted tables labels Nov 13, 2022
@ranquild ranquild added .Wanted: MLv2 Issues that will be fixed (or easier to fix, or possible to fix) when we have MLv2 Querying/Notebook Items specific to the Custom/Notebook query builder .Team/42 🌌 and removed Querying/GUI Query builder catch-all, including simple mode labels Aug 10, 2023
@npretto npretto self-assigned this Sep 28, 2023
@npretto
Copy link
Member

npretto commented Sep 29, 2023

This seems to have been fixed in 46.0, but was still broken in 45.4

@NevRA NevRA removed .Wanted: MLv2 Issues that will be fixed (or easier to fix, or possible to fix) when we have MLv2 .FixMBQLScope42 labels Oct 10, 2023
@npretto
Copy link
Member

npretto commented Oct 10, 2023

This was closed with #28945

This was referenced Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Frontend Priority:P2 Average run of the mill bug Querying/Notebook Items specific to the Custom/Notebook query builder Type:Bug Product defects Visualization/Tables Raw, summarized, and pivoted tables
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants