Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model loses temporal "group by" info #28599

Closed
nemanjaglumac opened this issue Feb 24, 2023 · 4 comments · Fixed by #33843
Closed

Model loses temporal "group by" info #28599

nemanjaglumac opened this issue Feb 24, 2023 · 4 comments · Fixed by #33843
Assignees
Labels
Priority:P2 Average run of the mill bug Querying/MBQL Querying/Models aka Datasets Type:Bug Product defects
Milestone

Comments

@nemanjaglumac
Copy link
Member

nemanjaglumac commented Feb 24, 2023

To Reproduce

  1. Sample Database > Orders > summarize "Count" grouped by "Created At: Year" > Save the question
  2. Turn into a model
  3. Notice that it loses temporal group by info and it's not possible to change granularity (time scale) in the "footer" anymore

Expected behavior
It should be behave exactly the same as the saved question it's made from.

Screenshots/videos
Question
image

Model
image

Information about your Metabase Installation:
local dev, master, 0a819fa, H2, Sample Database

Severity
P2

@nemanjaglumac nemanjaglumac added Type:Bug Product defects Priority:P2 Average run of the mill bug Querying/MBQL Querying/Models aka Datasets labels Feb 24, 2023
@darksciencebase
Copy link
Contributor

Note: the missing dropdown re-appears after clicking on "All Time" and then the "Apply" button.

@nemanjaglumac
Copy link
Member Author

@darksciencebase that makes this even worse.

Notice that once you do that, it's not showing model anymore, but a fresh query instead. So it's not even a previously saved question.

  1. Model icon is missing
  2. Try clicking on "Save" and it will ask you to save a new question

@ranquild
Copy link
Contributor

ranquild commented Apr 7, 2023

@nemanjaglumac @darksciencebase model doesn't lose temporal info here. It's embedded within the model, and in the simple mode the model is used as a tabular data source for a new question. What's wrong here is that we still display the footer to change the time filter while we shouldn't. Are you ok if I change the task description to include that part only?

@nemanjaglumac
Copy link
Member Author

@ranquild yes, please do.
Thank you

This was referenced Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:P2 Average run of the mill bug Querying/MBQL Querying/Models aka Datasets Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants