Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalar value font size noticeable delay on dashboards #29304

Closed
nemanjaglumac opened this issue Mar 17, 2023 · 2 comments · Fixed by #32534
Closed

Scalar value font size noticeable delay on dashboards #29304

nemanjaglumac opened this issue Mar 17, 2023 · 2 comments · Fixed by #32534
Assignees
Labels
.CSS .Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Reporting/Dashboards .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects Visualization/Scalars Numbers, progress bars, gauges
Milestone

Comments

@nemanjaglumac
Copy link
Member

Describe the bug
Scalar values in dashboard cards have noticeable delay in rendering the full font-size.

To Reproduce
Steps to reproduce the behavior (if you can reproduce the bug using the Sample Database, we will find the issue faster):

  1. Make an X-ray of Product table
  2. Go to automatically generated dashboard "A look at your Products table"
  3. Look at the first two cards in this dashboard and notice how the initial font size is small but then abruptly scales to the full font size about 1s later

Expected behavior
The transition should either be smooth or we shouldn't display the initial small font size.

Screenshots/videos
https://www.loom.com/share/7621add49aad47839d290b191eb598c8

Severity
Cosmetic, but it can be quite distracting especially if a dashboard has a lot of scalar cards

Additional context
Seems to be related to #24028 (cc @alxnddr )

@nemanjaglumac nemanjaglumac added Type:Bug Product defects .CSS Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Reporting/Dashboards .Frontend Visualization/Scalars Numbers, progress bars, gauges labels Mar 17, 2023
@WiNloSt
Copy link
Member

WiNloSt commented Jul 20, 2023

@WiNloSt
Copy link
Member

WiNloSt commented Jul 20, 2023

The problem is rather easy to fix. But I hit a huge problem when trying to test this.

First of all, testing in unit test isn't possible because ExplicitSize rely on the DOM dimension which it doesn't know.

Second, Cypress behaves differently between the window that has Cypress GUI and browsers. More context in https://metaboat.slack.com/archives/C505ZNNH4/p1689851816473099

This was referenced Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.CSS .Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Reporting/Dashboards .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects Visualization/Scalars Numbers, progress bars, gauges
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants