Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join is removed with "Removing invalid MBQL clause" joining two columns together with the same field ID #31769

Closed
Tracked by #30519
calherries opened this issue Jun 21, 2023 · 0 comments · Fixed by #31869
Assignees
Labels
.metabase-lib Label for tracking all issues related to the shared CLJC metabase-lib Priority:P2 Average run of the mill bug .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Type:Bug Product defects

Comments

@calherries
Copy link
Contributor

calherries commented Jun 21, 2023

Describe the bug

If you join two tables together on a column with the same field ID in the notebook editor, the join gets removed on save.

To Reproduce

Following the first three steps from #12930:

  1. Create question Q1 - Orders join with Products and People, summarized by Count, grouped by Category and Source
    image
  2. Create question Q2 - Products, summarized by Average Rating, grouped by Category
    image
  3. Custom question > Saved Questions > Q1 and join Q2 on Category.
image
  1. Click "Save". The Join should be removed with only Q1 remaining:
image

Expected behavior

Join should work

Logs

The browser console shows this warning on save:
image

Information about your Metabase installation

master, commit 7587d3cf1a6e35e593f900f98d266591a6160a31

Severity

High

Additional context

No response

@calherries calherries added Type:Bug Product defects .Needs Triage .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Team/QueryProcessor 🛠️ labels Jun 21, 2023
@camsaul camsaul added the .metabase-lib Label for tracking all issues related to the shared CLJC metabase-lib label Jun 21, 2023
@paoliniluis paoliniluis added Priority:P2 Average run of the mill bug and removed .Needs Triage labels Jun 23, 2023
@kulyk kulyk self-assigned this Jun 26, 2023
@kulyk kulyk mentioned this issue Jun 26, 2023
1 task
This was referenced Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.metabase-lib Label for tracking all issues related to the shared CLJC metabase-lib Priority:P2 Average run of the mill bug .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants