Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number filter does not changed from default in public access mode #31975

Closed
NemtsevSergey opened this issue Jun 29, 2023 · 2 comments · Fixed by #33374
Closed

Number filter does not changed from default in public access mode #31975

NemtsevSergey opened this issue Jun 29, 2023 · 2 comments · Fixed by #33374
Assignees
Labels
Client:Mobile Web and tablets and smaller screens Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/Parameters & Variables Filter widgets, field filters, variables etc. Reporting/Dashboards Type:Bug Product defects

Comments

@NemtsevSergey
Copy link

Describe the bug

When working with a report in regular mode from a phone, filters are collapsed into a mini mode, and opening them requires pressing a special button. In this mode, editing the numerical parameter works. However, if the same report is opened through a public link, the filters are displayed one by one. In this case, if we try to change the numerical filter, its value is reset to the default value and does not change.

To Reproduce

  1. Go to any report with number filter by public link from your mobile device
  2. Click on filter and change value, press next on mobile keyboard
  3. Value return back
  4. Expected - value should change.
video_2023-06-29_17-37-12.mp4

Expected behavior

Value should change

Logs

No response

Information about your Metabase installation

{ "browser-info": { "language": "ru-RU", "platform": "Linux armv81", "userAgent": "Mozilla/5.0 (Linux; Android 10; K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/114.0.0.0 Mobile Safari/537.36", "vendor": "Google Inc." }, "system-info": { "file.encoding": "UTF-8", "java.runtime.name": "OpenJDK Runtime Environment", "java.runtime.version": "11.0.19+7-post-Ubuntu-0ubuntu120.04.1", "java.vendor": "Ubuntu", "java.vendor.url": "https://ubuntu.com/", "java.version": "11.0.19", "java.vm.name": "OpenJDK 64-Bit Server VM", "java.vm.version": "11.0.19+7-post-Ubuntu-0ubuntu120.04.1", "os.name": "Linux", "os.version": "5.4.0-144-generic", "user.language": "en", "user.timezone": "Etc/UTC" }, "metabase-info": { "databases": [ "postgres", "sqlserver" ], "hosting-env": "unknown", "application-database": "postgres", "application-database-details": { "database": { "name": "PostgreSQL", "version": "14.3 (Ubuntu 14.3-1.pgdg20.04+1)" }, "jdbc-driver": { "name": "PostgreSQL JDBC Driver", "version": "42.5.1" } }, "run-mode": "prod", "version": { "date": "2023-06-14", "tag": "v0.46.5", "branch": "release-x.46.x", "hash": "272e3e6" }, "settings": { "report-timezone": "Asia/Vladivostok" } } }

Severity

Blocking user from work from mobile devices

Additional context

No response

@paoliniluis paoliniluis added Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Client:Mobile Web and tablets and smaller screens Reporting/Dashboards Querying/Parameters & Variables Filter widgets, field filters, variables etc. and removed .Needs Triage labels Jun 29, 2023
@uladzimirdev uladzimirdev self-assigned this Aug 16, 2023
@uladzimirdev
Copy link
Contributor

@NemtsevSergey could you please provide more information about the bug? I can't reproduce it with the version 0.46.5 you reported. Did you have anything specific in the question on that dashboard, maybe custom column or custom expression?

@uladzimirdev
Copy link
Contributor

I was able to reproduce the issue only with SQL question with parameters, covered that case in #33374

@NemtsevSergey please let me know if your issue appeared with different setup, it would be nice if you could provide clear steps to reproduce the problem.

This was referenced Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client:Mobile Web and tablets and smaller screens Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/Parameters & Variables Filter widgets, field filters, variables etc. Reporting/Dashboards Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants