Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard cards which contain a filter at question level gets refreshed even if Dashboard Filter is not linked to the card #32444

Closed
Tony-metabase opened this issue Jul 17, 2023 · 1 comment · Fixed by #33197
Assignees
Labels
.Frontend .Performance Priority:P2 Average run of the mill bug Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Reporting/Dashboards Type:Bug Product defects

Comments

@Tony-metabase
Copy link
Contributor

Describe the bug

Seems to be related to #8030.

In this case though cards are getting refreshed when a filter that is not linked to them is changed. Note this happens only for cards that are filtered at question level

Important that the behavior in-app dashboard is also reflected on Public and Embedding, so it doesn't divert in behavior.

To Reproduce

  1. Go to Question -> Sample DB -> Orders -> Filter by Total is not Empty
image
  1. Add it to a Dashboard
  2. Add any type of Filter but don't link it to anything
image
  1. Change Value of the filter and see question getting refreshed.

NOTE: This doesn't happen for cards that don't have a filter at question level

Expected behavior

Question is not refreshed if no filter is linked to it

Logs

None

Information about your Metabase installation

1.46.6 and master

Severity

Would say major since it's a performance issue and a regression (or a partial fix #8030))

Additional context

No response

@Tony-metabase Tony-metabase added Type:Bug Product defects Priority:P2 Average run of the mill bug .Performance Reporting/Dashboards Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Frontend labels Jul 17, 2023
@paoliniluis paoliniluis added the .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. label Jul 17, 2023
@paoliniluis
Copy link
Contributor

This also runs the question, so it's also going to overload the DB without even wanting

This was referenced Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Frontend .Performance Priority:P2 Average run of the mill bug Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Reporting/Dashboards Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants