Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We're not signaling when a card is loading if you change the filters on a dashboard and switch tabs #33767

Closed
ignacio-mb opened this issue Sep 6, 2023 · 2 comments · Fixed by #37134
Assignees
Labels
.Frontend Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/Parameters & Variables Filter widgets, field filters, variables etc. Reporting/Dashboards .Team/QueryingComponents Type:Bug Product defects
Milestone

Comments

@ignacio-mb
Copy link
Contributor

ignacio-mb commented Sep 6, 2023

Describe the bug

When you have a loaded dashboard and apply a filter, if you have a card in another tab that is connected to the same filter, the card in another tab being filtered doesn't signal loading and, depending on the time, it may result in confusing results.

To Reproduce

  1. Build a beautiful dashboard full of reports and complex questions and 2 tabs
  2. Add filters to the dashboard and connect cards to it, in both tabs. I used the Orders table for almost every report to connect to filters, and in the video, I put the same card on both tabs to visually see the bug.
  3. Apply a filter in tab 1. When it finishes loading, change to tab 2. As filters are currently global (not tab-specific), they will apply to the cards in the new tab as well.
  4. See that there is no loading signal

For a more visual impact, in the following video I added the same cards that should be changed to the two tabs. The card in Tab 1 took almost 10 seconds without a loading signal. It's all Sample Database information.

Screen.Recording.2023-09-06.at.6.04.33.PM.mov

Expected behavior

The loading signal on cards affected by the filter should be there

Logs

No response

Information about your Metabase installation

v1.47.0

Severity

It can show misleading information.

Additional context

@ignacio-mb ignacio-mb added Type:Bug Product defects Reporting/Dashboards Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Needs Triage labels Sep 6, 2023
@paoliniluis paoliniluis added Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness and removed .Needs Triage labels Sep 7, 2023
@paoliniluis
Copy link
Contributor

Flagging as P1 as it can confuse the users

@ranquild ranquild added .Team/DashViz Dashboard and Viz team and removed .Team/42 (DEPRECATED) labels Nov 13, 2023
@oleggromov oleggromov self-assigned this Dec 6, 2023
@NevRA
Copy link
Contributor

NevRA commented Dec 7, 2023

@perivamsi Oleg will fix it as a part of onboarding to the Parameters scope

This was referenced Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Frontend Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/Parameters & Variables Filter widgets, field filters, variables etc. Reporting/Dashboards .Team/QueryingComponents Type:Bug Product defects
Projects
None yet
7 participants