Text filters shown as input box in embed instead as dropdown

[albertoperdomo]

Describe the bug

Decided to open this issue after spending some time reproducing #31347 and noticing the behavior has changed a lot.
Essentially, you expect filters to look the same in the embed, in the embed preview and in the dashboard inside of Metabase.

Findings:

• filter set as dropdown in dashboard, no default value for filter in dashboard, editable in embed -> filter is rendered as input box in embed
• filter set as dropdown in dashboard, default value set for filter in dashboard, locked in embed -> filter is rendered as input box in embed
• filter set as droddown in dashboard, default value set for filter in dashboard, editable in embed -> filter is rendered as dropdown in embed as it should, but it's rendered differently in the preview

The preview features and linking of the filters seems to work properly, unlike reported in #31347.

To Reproduce

1. Go to New -> Question -> Products -> Save
2. Create New Dashboard -> Add 3 Filters and Add the above question then link them to column Category

3. Link the first filter to the second one -> Save 4. Confirm that the link is working by selecting Doohickey for Second Filter and Gadget,Gizmo for Third filter ... Notice that on metabase works as expected and First filter only shows Doohickey as an option 5. Go to Sharing -> Embed your application -> Make the filters editable -> Publish 6. The filters are rendered in the embed and preview as input boxes instead of as dropdown

7. Edit the dashboard, set the default value for text 1 as Doohickey -> Save

8. Go to Sharing -> Embed your application -> Preview

9. In the preview Text filter is still rendered as input box but text 1 is rendered as multi-select, in the embed it is a proper dropdown

Text:

Text 1 in preview inside of UI:

Text 1 opening iframe from preview URL in incognito mode:

10. Copy the iframe URL from the preview using inspect and open it in incognito mode. You will see that text and text1 are now rendered as dropdown and also that the linking of the filters is working as expected. Text2 is still rendered as input box.

11. Set text1 to locked, set a preview value for it as "Doohickey", publish, copy the iframe URL from the preview using inspect, open it in incognito mode. The results are properly filtered (Doohickey only), but text filter shows again as input box even though there is a default value

Expected behavior

The filters should look the same across dashboard in MB, embed preview and real life embed. The combination of setting a default value in the dashboard and setting the filter as editable triggers this consistent behavior but it should not be needed

Logs

No response

Information about your Metabase installation

Metabase v1.48.1

Severity

Might be blocking in certain use cases

Additional context

No response

[albertoperdomo]

Setting a default value for both filters and embedding triggers the correct behavior and rendering on the embed:

[Tony-metabase]

There was already some research on linked filters by @WiNloSt which is good to have it here for reference:

#31347 (comment)

[WiNloSt]

@albertoperdomo I might found 2 issues in this single issue.

1. The preview embed on Metabase instance and the preview embed when viewing it directly (copy the iframe URL to a new tab) will result in parameters behaving differently because the embed preview will call an unexistent API. This should be solved in this PR Fix dashboard parameter values in embed preview not working #37972

2. When we set a parameter to locked, all other filters that map to the same locked parameter won't be working in embedding anymore. I think this might be a BE issue, so I'd need some BE engineer aid here.

   in embedding, when calling the dashboard endpoint when all parameters are set to editable we'll get param_fields (1) in the response which makes FE show the dropdown. But when we set any of the parameters to anything except editible (locked, or disabled), we'll not get any value in param_fields (2)

   1. 
   2. 

[Tony-metabase]

I am reopening this one since I am testing to make sure the embedding behaves the same as metabase and I am getting a text filter everywhere so I cannot even test if linked filters are working as expected on embedding (i.e. similar to the metabase dashboard)

Both when filters are set to Disabled or Locked