Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repro #36122 - Table Metadata having 2 foreign keys from the same table pointing to the same key cause implicit joins to only show 1 #38085

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

kamilmielnik
Copy link
Contributor

Closes #36122

@kamilmielnik kamilmielnik self-assigned this Jan 24, 2024
@kamilmielnik kamilmielnik marked this pull request as ready for review January 24, 2024 11:36
@kamilmielnik kamilmielnik added no-backport Do not backport this PR to any branch .Team/QueryingComponents labels Jan 24, 2024
@kamilmielnik kamilmielnik requested a review from a team January 24, 2024 11:36
@kamilmielnik kamilmielnik enabled auto-merge (squash) January 24, 2024 11:36
Copy link

replay-io bot commented Jan 24, 2024

StatusComplete ↗︎
Commit7880953
Results
⚠️ 1 Flaky
  • should validate approved email domains for a dashboard subscription in the audit app
2235 Passed

@kamilmielnik kamilmielnik changed the title Add repro test for #36122 Repro #36122 - Table Metadata having 2 foreign keys from the same table pointing to the same key cause implicit joins to only show 1 Jan 24, 2024
@uladzimirdev
Copy link
Contributor

can we run a stress test for it?

@kamilmielnik
Copy link
Contributor Author

can we run a stress test for it?

All green: https://github.com/metabase/metabase/actions/runs/7653758434

@kamilmielnik kamilmielnik merged commit 0511c9c into master Jan 25, 2024
107 checks passed
@kamilmielnik kamilmielnik deleted the 36122-fks branch January 25, 2024 11:38
Copy link

@kamilmielnik Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

sloansparger pushed a commit that referenced this pull request Feb 5, 2024
…le pointing to the same key cause implicit joins to only show 1 (#38085)

* Add a repro for 36122

* Improve assertions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch support/Repro .Team/QueryingComponents
Projects
None yet
3 participants