-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the "remove" button to the sidebar footer #38050
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
frontend/src/metabase/parameters/components/ParameterSidebar/ParameterSidebar.tsx
Outdated
Show resolved
Hide resolved
035ed0c
to
a69e950
Compare
66c4759
to
e3e6404
Compare
variant="subtle" | ||
color="error" | ||
onClick={onRemove} | ||
style={{ paddingLeft: 0, paddingRight: 0 }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're probably awaiting a transition from mantine 6 to 7, I am adding an inline style, which will be replaced with a CSS class once migrated.
@oleggromov Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
* Convert Sidebar to TSX * Move remove button to the sidebar footer * Change styles to styled components * Fix tests
Epic: #36524
Description
This is one of the obvious steps in the 2nd milestone of the epic.
The remove button obviously doesn't belong to where it was so we're moving it to the bottom of the sidebar.
Since I've touched the Sidebar, I am also converting it to Typescript and updating styles.
Before
After