Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable video uploads for successful Cypress tests #13747

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

nemanjaglumac
Copy link
Member

@nemanjaglumac nemanjaglumac commented Nov 10, 2020

Status

PENDING CI

What does this PR accomplish?

  • It disables video uploads for Cypress tests that passed, hopefully saving us a couple of minutes for every CI run.

Additional info:

@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #13747 (f17c34d) into master (d1eef9a) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13747      +/-   ##
==========================================
+ Coverage   83.36%   83.42%   +0.05%     
==========================================
  Files         372      372              
  Lines       29397    29397              
  Branches     2143     2142       -1     
==========================================
+ Hits        24508    24523      +15     
+ Misses       2746     2732      -14     
+ Partials     2143     2142       -1     
Impacted Files Coverage Δ
src/metabase/task/sync_databases.clj 76.41% <0.00%> (+4.71%) ⬆️
src/metabase/logger.clj 78.12% <0.00%> (+31.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1eef9a...f17c34d. Read the comment docs.

@nemanjaglumac nemanjaglumac changed the title Disable video uploads for Cypress passes Disable video uploads for successful Cypress tests Nov 11, 2020
Copy link
Contributor

@ariya ariya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes a lot of sense, successful tests video should be the same anyway for every single run.

👍

@nemanjaglumac nemanjaglumac merged commit dc53ed1 into master Nov 11, 2020
@nemanjaglumac nemanjaglumac deleted the cypress-video-uploads branch November 11, 2020 14:45
nemanjaglumac added a commit that referenced this pull request Nov 26, 2020
* Improve Cypress helper functions with log messages (#13749) [ci skip]

- Adds helpful log message to various helper functions in `frontend/test/__support__/cypress.js`.
    - `--- Logging in as ${user} ---` to `signIn()`
    - `--- Signing out ---` to `signOut()` and
    - `--- Restore Data Set ---` to `restore()`

* Disable video uploads for successful Cypress tests (#13747)

* https://docs.cypress.io/guides/references/configuration.html#Videos

* Add Cypress file download testing (#13430)

* Add `read-excel-file` library

* Add "file download" config to `cypress-plugins.js`

* Switch to SheetJS for xlsx/csv testing and upgrade Cypress because of cypress-io/cypress#7382


Co-authored-by: Damon P. Cortesi <d.lifehacker@gmail.com>

* Quarantine `field.cy.spec.js` (#13896)

Full quarantine list in #13682.

* Fix smoke tests (#13897)

Failure happened because of the obsolete references to the now updated actions/drill-through popover menu.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants